Save some gcc footprint (15 KB) in ExplodedFrameState.

Save some gcc footprint (15 KB) in ExplodedFrameState.

Inlining the assignment and copy constructor for a class
like ExplodedFrameState exploded the machine code in stl::vector.

gcc:
Total change: -14969 bytes
==========================
  2 added, totalling +504 bytes across 1 sources
  1 removed, totalling -3387 bytes across 1 sources
  0 added, totalling 0 bytes across 0 sources
  3 shrunk, for a net change of -12086 bytes (14716 bytes before, 2630 bytes after) across 2 sources

It also helps for clang which normally ignores programmers hints to inline anyway:
clang:
Total change: -918 bytes
========================
  1 added, totalling +263 bytes across 1 sources
  3 removed, totalling -1098 bytes across 2 sources
  2 grown, for a net change of +161 bytes (1822 bytes before, 1983 bytes after) across 1 sources
  1 shrunk, for a net change of -244 bytes (1401 bytes before, 1157 bytes after) across 1 sources

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284424

[Daniel Bratell, 2014-07-21 12:38:24]

jochen, could you please take a look at this footprint patch?

It's some code that violates the "no-inline-copy-constructor" rule and actually
is punished badly for it by gcc (less so by clang).

[jochen (gone - plz use gerrit), 2014-07-21 13:09:12]

lgtm

[Daniel Bratell, 2014-07-21 13:29:51]

The CQ bit was checked by bratell@opera.com

[commit-bot: I haz the power, 2014-07-21 13:31:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bratell@opera.com/400923002/20001

[commit-bot: I haz the power, 2014-07-21 14:12:35]

Change committed as 284424