Check that Service Workers are registered from secure origins.

Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

Index: Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp
diff --git a/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp b/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..89f05d175bc8c01b34f539b363d1d3628b7b4d56
--- /dev/null
+++ b/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp
@@ -0,0 +1,344 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "config.h"
+#include "modules/serviceworkers/ServiceWorkerContainer.h"
+
+#include "bindings/core/v8/Dictionary.h"
+#include "bindings/core/v8/ScriptFunction.h"
+#include "bindings/core/v8/ScriptPromise.h"
+#include "bindings/core/v8/ScriptState.h"
+#include "bindings/core/v8/V8DOMException.h"
+#include "bindings/core/v8/V8GCController.h"
+#include "core/dom/DOMException.h"
+#include "core/dom/Document.h"
+#include "core/dom/ExecutionContext.h"
+#include "core/testing/DummyPageHolder.h"
+#include "modules/serviceworkers/ServiceWorkerContainerClient.h"
+#include "platform/weborigin/KURL.h"
+#include "platform/weborigin/SecurityOrigin.h"
+#include "public/platform/WebServiceWorkerProvider.h"
+#include "public/platform/WebURL.h"
+#include "wtf/OwnPtr.h"
+#include "wtf/PassOwnPtr.h"
+#include "wtf/text/WTFString.h"
+#include <gtest/gtest.h>
+#include <v8.h>
+
+using namespace WebCore;

[horo, 2014/07/22 13:00:48]

s/WebCore/blink/

https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/gGqYHU5yvrw

+
+namespace {
+
+// Promise-related test support.
+
+struct StubScriptFunction {
+public:
+    StubScriptFunction()
+        : m_callCount(0)
+    {
+    }
+
+    // The returned ScriptFunction can outlive the StubScriptFunction,
+    // but it should not be called after the StubScriptFunction dies.
+    PassOwnPtr<ScriptFunction> function(v8::Isolate* isolate)
+    {
+        return adoptPtr(new ScriptFunctionImpl(isolate, *this));
+    }
+
+    size_t callCount() { return m_callCount; }
+    ScriptValue arg() { return m_arg; }
+
+private:
+    size_t m_callCount;
+    ScriptValue m_arg;
+
+    class ScriptFunctionImpl : public ScriptFunction {
+    public:
+        ScriptFunctionImpl(v8::Isolate* isolate, StubScriptFunction& owner)
+            : ScriptFunction(isolate)
+            , m_owner(owner)
+        {
+        }
+
+        virtual ScriptValue call(ScriptValue arg) OVERRIDE
+        {
+            m_owner.m_arg = arg;
+            m_owner.m_callCount++;
+            return ScriptValue();
+        }
+
+    private:
+        StubScriptFunction& m_owner;
+    };
+};
+
+class ScriptValueTest {
+public:
+    virtual ~ScriptValueTest() { }
+    virtual void operator()(ScriptValue) const = 0;
+};
+
+// Runs microtasks and expects |promise| to be rejected. Calls
+// |valueTest| with the value passed to |reject|, if any.
+void expectRejected(ScriptPromise& promise, const ScriptValueTest& valueTest)
+{
+    StubScriptFunction resolved, rejected;
+    promise.then(resolved.function(promise.isolate()), rejected.function(promise.isolate()));
+    promise.isolate()->RunMicrotasks();
+    EXPECT_EQ(0ul, resolved.callCount());
+    EXPECT_EQ(1ul, rejected.callCount());
+    if (rejected.callCount())
+        valueTest(rejected.arg());
+}
+
+// DOM-related test support.
+
+// Matches a ScriptValue and a DOMException with a specific name and message.
+class ExpectDOMException : public ScriptValueTest {
+public:
+    ExpectDOMException(const String& expectedName, const String& expectedMessage)
+        : m_expectedName(expectedName)
+        , m_expectedMessage(expectedMessage)
+    {
+    }
+
+    virtual ~ExpectDOMException() OVERRIDE { }
+
+    virtual void operator()(ScriptValue value) const OVERRIDE
+    {
+        DOMException* exception = V8DOMException::toNativeWithTypeCheck(value.isolate(), value.v8Value());
+        EXPECT_TRUE(exception) << "the value should be a DOMException";
+        if (!exception)
+            return;
+        EXPECT_EQ(m_expectedName, exception->name());
+        EXPECT_EQ(m_expectedMessage, exception->message());
+    }
+
+private:
+    String m_expectedName;
+    String m_expectedMessage;
+};
+
+// Service Worker-specific tests.
+
+class NotReachedWebServiceWorkerProvider : public WebServiceWorkerProvider {
+public:
+    virtual ~NotReachedWebServiceWorkerProvider() OVERRIDE { }
+
+    virtual void registerServiceWorker(const WebURL& pattern, const WebURL& scriptURL, WebServiceWorkerCallbacks* callbacks) OVERRIDE
+    {
+        ADD_FAILURE() << "the provider should not be called to register a Service Worker";
+        delete callbacks;
+    }
+
+    virtual void unregisterServiceWorker(const WebURL& pattern, WebServiceWorkerCallbacks* callbacks) OVERRIDE
+    {
+        ADD_FAILURE() << "the provider should not be called to unregister a Service Worker";
+        delete callbacks;
+    }
+};
+
+class ServiceWorkerContainerTest : public ::testing::Test {
+protected:
+    ServiceWorkerContainerTest()
+        : m_page(DummyPageHolder::create())
+    {
+    }
+
+    ~ServiceWorkerContainerTest()
+    {
+        m_page.clear();
+        V8GCController::collectGarbage(isolate());
+    }
+
+    ExecutionContext* executionContext() { return &(m_page->document()); }
+    v8::Isolate* isolate() { return v8::Isolate::GetCurrent(); }
+    ScriptState* scriptState() { return ScriptState::forMainWorld(m_page->document().frame()); }
+
+    void provide(PassOwnPtr<WebServiceWorkerProvider> provider)
+    {
+        m_page->document().DocumentSupplementable::provideSupplement(ServiceWorkerContainerClient::supplementName(), ServiceWorkerContainerClient::create(provider));
+    }
+
+    void setPageURL(const String& url)
+    {
+        // For URL completion.
+        m_page->document().setBaseURLOverride(KURL(KURL(), url));
+
+        // The basis for security checks.
+        m_page->document().setSecurityOrigin(SecurityOrigin::createFromString(url));
+    }
+
+    void testRegisterRejected(const String& scriptURL, const String& scope, const ScriptValueTest& valueTest)
+    {
+        // When the registration is rejected, a register call must not reach
+        // the provider.
+        provide(adoptPtr(new NotReachedWebServiceWorkerProvider()));
+
+        RefPtrWillBeRawPtr<ServiceWorkerContainer> container = ServiceWorkerContainer::create(executionContext());
+        ScriptState::Scope scriptScope(scriptState());
+        Dictionary options = Dictionary::createEmpty(isolate());
+        EXPECT_TRUE(options.set("scope", scope));
+        ScriptPromise promise = container->registerServiceWorker(scriptState(), scriptURL, options);
+        expectRejected(promise, valueTest);
+
+        container->willBeDetachedFromFrame();
+    }
+
+    void testUnregisterRejected(const String& scope, const ScriptValueTest& valueTest)
+    {
+        provide(adoptPtr(new NotReachedWebServiceWorkerProvider()));
+
+        RefPtrWillBeRawPtr<ServiceWorkerContainer> container = ServiceWorkerContainer::create(executionContext());
+        ScriptState::Scope scriptScope(scriptState());
+        Dictionary options = Dictionary::createEmpty(isolate());
+        EXPECT_TRUE(options.set("scope", scope));
+        ScriptPromise promise = container->unregisterServiceWorker(scriptState(), scope);
+        expectRejected(promise, valueTest);
+
+        container->willBeDetachedFromFrame();
+    }
+
+private:
+    OwnPtr<DummyPageHolder> m_page;
+};
+
+TEST_F(ServiceWorkerContainerTest, Register_NonSecureOriginIsRejected)
+{
+    setPageURL("http://www.example.com/");
+    testRegisterRejected(
+        "http://www.example.com/worker.js",
+        "http://www.example.com/*",
+        ExpectDOMException("SecurityError", "Service Workers are only supported over secure origins."));
+}
+
+TEST_F(ServiceWorkerContainerTest, Register_CrossOriginScriptIsRejected)
+{
+    setPageURL("https://www.example.com");
+    testRegisterRejected(
+        "https://www.example.com:8080/", // Differs by port
+        "https://www.example.com/*",
+        ExpectDOMException("SecurityError", "The origin of the script must match the current origin."));
+}
+
+TEST_F(ServiceWorkerContainerTest, Register_CrossOriginScopeIsRejected)
+{
+    setPageURL("https://www.example.com");
+    testRegisterRejected(
+        "https://www.example.com",
+        "wss://www.example.com/*", // Differs by protocol
+        ExpectDOMException("SecurityError", "The scope must match the current origin."));
+}
+
+TEST_F(ServiceWorkerContainerTest, Unregister_NonSecureOriginIsRejected)
+{
+    setPageURL("http://www.example.com");
+    testUnregisterRejected(
+        "*",
+        ExpectDOMException("SecurityError", "Service Workers are only supported over secure origins."));
+}
+
+TEST_F(ServiceWorkerContainerTest, Unregister_CrossOriginScopeIsRejected)
+{
+    setPageURL("https://www.example.com");
+    testUnregisterRejected(
+        "https://example.com/*", // Differs by host
+        ExpectDOMException("SecurityError", "The scope must match the current origin."));
+}
+
+class StubWebServiceWorkerProvider {
+public:
+    StubWebServiceWorkerProvider()
+        : m_registerCallCount(0)
+        , m_unregisterCallCount(0)
+    {
+    }
+
+    // Creates a WebServiceWorkerProvider. This can outlive the
+    // StubWebServiceWorkerProvider, but |registerServiceWorker| and
+    // other methods must not be called after the
+    // StubWebServiceWorkerProvider dies.
+    PassOwnPtr<WebServiceWorkerProvider> provider()
+    {
+        return adoptPtr(new WebServiceWorkerProviderImpl(*this));
+    }
+
+    size_t registerCallCount() { return m_registerCallCount; }
+    const WebURL& registerScope() { return m_registerScope; }
+    const WebURL& registerScriptURL() { return m_registerScriptURL; }
+    size_t unregisterCallCount() { return m_unregisterCallCount; }
+    const WebURL& unregisterScope() { return m_unregisterScope; }
+
+private:
+    class WebServiceWorkerProviderImpl : public WebServiceWorkerProvider {
+    public:
+        WebServiceWorkerProviderImpl(StubWebServiceWorkerProvider& owner)
+            : m_owner(owner)
+        {
+        }
+
+        virtual ~WebServiceWorkerProviderImpl() OVERRIDE { }
+
+        virtual void registerServiceWorker(const WebURL& pattern, const WebURL& scriptURL, WebServiceWorkerCallbacks* callbacks) OVERRIDE
+        {
+            m_owner.m_registerCallCount++;
+            m_owner.m_registerScope = pattern;
+            m_owner.m_registerScriptURL = scriptURL;
+            m_callbacksToDelete.append(adoptPtr(callbacks));
+        }
+
+        virtual void unregisterServiceWorker(const WebURL& pattern, WebServiceWorkerCallbacks* callbacks) OVERRIDE
+        {
+            m_owner.m_unregisterCallCount++;
+            m_owner.m_unregisterScope = pattern;
+            m_callbacksToDelete.append(adoptPtr(callbacks));
+        }
+
+    private:
+        StubWebServiceWorkerProvider& m_owner;
+        Vector<OwnPtr<WebServiceWorkerCallbacks> > m_callbacksToDelete;
+    };
+
+private:
+    size_t m_registerCallCount;
+    WebURL m_registerScope;
+    WebURL m_registerScriptURL;
+    size_t m_unregisterCallCount;
+    WebURL m_unregisterScope;
+};
+
+TEST_F(ServiceWorkerContainerTest, RegisterUnregister_NonHttpsSecureOriginDelegatesToProvider)
+{
+    setPageURL("http://localhost/x/index.html");
+
+    StubWebServiceWorkerProvider stubProvider;
+    provide(stubProvider.provider());
+
+    RefPtrWillBeRawPtr<ServiceWorkerContainer> container = ServiceWorkerContainer::create(executionContext());
+
+    // register
+    {
+        ScriptState::Scope scriptScope(scriptState());
+        Dictionary options = Dictionary::createEmpty(isolate());
+        EXPECT_TRUE(options.set("scope", "y/*"));
+        container->registerServiceWorker(scriptState(), "/z/worker.js", options);
+
+        EXPECT_EQ(1ul, stubProvider.registerCallCount());
+        EXPECT_EQ(WebURL(KURL(KURL(), "http://localhost/x/y/*")), stubProvider.registerScope());
+        EXPECT_EQ(WebURL(KURL(KURL(), "http://localhost/z/worker.js")), stubProvider.registerScriptURL());
+    }
+
+    // unregister
+    {
+        ScriptState::Scope scriptScope(scriptState());
+        container->unregisterServiceWorker(scriptState(), "y/*");
+
+        EXPECT_EQ(1ul, stubProvider.unregisterCallCount());
+        EXPECT_EQ(WebURL(KURL(KURL(), "http://localhost/x/y/*")), stubProvider.unregisterScope());
+    }
+
+    container->willBeDetachedFromFrame();
+}
+
+} // namespace