Issue 400893007: Add Custom Named property getters for cssStyleDeclaration to determine the existence of a property.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 400893007: Add Custom Named property getters for cssStyleDeclaration to determine the existence of a property. (Closed)

Created:
6 years, 5 months ago by Emily Fortuna

Modified:
6 years, 5 months ago

Reviewers:
Leaf, terry

CC:
reviews+dom_dartlang.org

Base URL:
svn://svn.chromium.org/blink/branches/dart/1985

Visibility:
Public.

More Reviews

Description

Add Custom Named property getters for cssStyleDeclaration to determine the existence of a property. BUG= R=leafp@google.com Committed: https://src.chromium.org/viewvc/multivm/branches/1650/blink?view=rev&revision=178680

Patch Set 3 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+183 lines, -16 lines)			Patch
M	Source/bindings/dart/custom/DartCSSStyleDeclarationCustom.cpp	View	1	2 chunks	+132 lines, -0 lines	0 comments	Download
M	Source/bindings/dart/scripts/templates/interface_base_cpp.template	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	Source/bindings/dart/scripts/templates/interface_cpp.template	View	1 2	3 chunks	+40 lines, -16 lines	0 comments	Download
M	Source/bindings/dart/scripts/templates/interface_h.template	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Leaf

1 comment, then lgtm https://codereview.chromium.org/400893007/diff/20002/Source/bindings/dart/scripts/templates/interface_cpp.template File Source/bindings/dart/scripts/templates/interface_cpp.template (right): https://codereview.chromium.org/400893007/diff/20002/Source/bindings/dart/scripts/templates/interface_cpp.template#newcode7 Source/bindings/dart/scripts/templates/interface_cpp.template:7: {% macro resolver_indexed_name(class_name, name, argument) ...

6 years, 5 months ago (2014-07-22 17:02:29 UTC) #2

Emily Fortuna

6 years, 5 months ago (2014-07-22 18:02:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r178680 (presubmit successful).

Expand Messages | Collapse Messages

Issue 400893007: Add Custom Named property getters for cssStyleDeclaration to determine the existence of a property. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages