Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 400893002: Resize webstore icons to a known size before placing them in the app list model. (Closed)

Created:
6 years, 5 months ago by tapted
Modified:
6 years, 5 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Resize webstore icons to a known size before placing them in the app list model. Icons from the webstore can be unusual sizes. Once installed, ExtensionAppItem uses extension_misc::EXTENSION_ICON_MEDIUM (48) to load it, so be consistent with that. BUG=338253 TEST=(CrOS) Start installing a large app from the webstore (e.g. tank riders). While it has a progress bar, drag it around the app launcher - the icon should grow a little, not a lot (see bug for screenshots). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284879

Patch Set 1 #

Patch Set 2 : fix include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M chrome/browser/ui/app_list/extension_app_model_builder.cc View 1 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tapted
6 years, 5 months ago (2014-07-23 03:33:00 UTC) #1
calamity
lgtm
6 years, 5 months ago (2014-07-23 03:50:34 UTC) #2
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 5 months ago (2014-07-23 03:51:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/400893002/20001
6 years, 5 months ago (2014-07-23 03:52:43 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win8_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 04:56:07 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 07:05:47 UTC) #6
Message was sent while issue was closed.
Change committed as 284879

Powered by Google App Engine
This is Rietveld 408576698