Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 400863002: [Telemetry] Allow the Monsoon to power the device under test. (Closed)

Created:
6 years, 5 months ago by tonyg
Modified:
6 years, 5 months ago
Reviewers:
dtu, qsr
CC:
chromium-reviews, telemetry+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Allow the Monsoon to power the device under test. The monsoon provides power for the device, so for devices with no real battery, we need a chance to turn them on after the monsoon enables voltage output to the device. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285005

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -15 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py View 1 3 chunks +33 lines, -8 lines 1 comment Download
M tools/telemetry/telemetry/core/platform/power_monitor/monsoon_power_monitor.py View 1 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tonyg
6 years, 5 months ago (2014-07-23 00:14:41 UTC) #1
qsr
LGTM with nit https://chromiumcodereview.appspot.com/400863002/diff/20001/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py File tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py (right): https://chromiumcodereview.appspot.com/400863002/diff/20001/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py#newcode200 tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py:200: m.SetVoltage(3.8) We are using 4V in ...
6 years, 5 months ago (2014-07-23 08:27:41 UTC) #2
tonyg
On 2014/07/23 08:27:41, qsr_OoO_until_Aug_17 wrote: > LGTM with nit > > https://chromiumcodereview.appspot.com/400863002/diff/20001/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py > File tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py ...
6 years, 5 months ago (2014-07-23 15:51:21 UTC) #3
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 5 months ago (2014-07-23 15:51:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/400863002/20001
6 years, 5 months ago (2014-07-23 15:53:20 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 19:00:12 UTC) #6
Message was sent while issue was closed.
Change committed as 285005

Powered by Google App Engine
This is Rietveld 408576698