Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: media/filters/audio_renderer_impl.cc

Issue 400853002: Drop time from media::{Audio,Video}Renderer::StartPlayingFrom(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/audio_renderer_impl.cc
diff --git a/media/filters/audio_renderer_impl.cc b/media/filters/audio_renderer_impl.cc
index bbe0d786b98472e2492063e8c35907432d6a9ca4..9b0c098b191ecbdfae2fa85e03c60f2f855aed0b 100644
--- a/media/filters/audio_renderer_impl.cc
+++ b/media/filters/audio_renderer_impl.cc
@@ -130,6 +130,17 @@ void AudioRendererImpl::StopRendering_Locked() {
sink_->Pause();
}
+void AudioRendererImpl::SetMediaTime(base::TimeDelta time) {
+ DVLOG(1) << __FUNCTION__ << "(" << time.InMicroseconds() << ")";
+ DCHECK(task_runner_->BelongsToCurrentThread());
+
+ base::AutoLock auto_lock(lock_);
+ DCHECK(!rendering_);
+ DCHECK_EQ(state_, kFlushed);
+
+ start_timestamp_ = time;
+}
+
void AudioRendererImpl::Flush(const base::Closure& callback) {
DVLOG(1) << __FUNCTION__;
DCHECK(task_runner_->BelongsToCurrentThread());
@@ -219,8 +230,8 @@ void AudioRendererImpl::Stop(const base::Closure& callback) {
task_runner_->PostTask(FROM_HERE, callback);
}
-void AudioRendererImpl::StartPlayingFrom(base::TimeDelta timestamp) {
- DVLOG(1) << __FUNCTION__ << "(" << timestamp.InMicroseconds() << ")";
+void AudioRendererImpl::StartPlaying() {
+ DVLOG(1) << __FUNCTION__;
DCHECK(task_runner_->BelongsToCurrentThread());
base::AutoLock auto_lock(lock_);
@@ -230,8 +241,6 @@ void AudioRendererImpl::StartPlayingFrom(base::TimeDelta timestamp) {
DCHECK(!pending_read_) << "Pending read must complete before seeking";
ChangeState_Locked(kPlaying);
- start_timestamp_ = timestamp;
-
AttemptRead_Locked();
}

Powered by Google App Engine
This is Rietveld 408576698