Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Unified Diff: media/base/audio_renderer.h

Issue 400853002: Drop time from media::{Audio,Video}Renderer::StartPlayingFrom(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/mock_filters.h » ('j') | media/filters/audio_renderer_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/audio_renderer.h
diff --git a/media/base/audio_renderer.h b/media/base/audio_renderer.h
index 48ab6846b73ee2738c70ce9435454a7afa3aa873..8a34ce9aeff568a065517d7261b3c96a5072afa3 100644
--- a/media/base/audio_renderer.h
+++ b/media/base/audio_renderer.h
@@ -48,12 +48,22 @@ class MEDIA_EXPORT AudioRenderer {
// Signal audio playback to start at the current rate. It is expected that
// |time_cb| will eventually start being run with time updates.
+ //
+ // TODO(scherkus): Fold into TimeSource API.
virtual void StartRendering() = 0;
// Signal audio playback to stop until further notice. It is expected that
// |time_cb| will no longer be run.
+ //
+ // TODO(scherkus): Fold into TimeSource API.
virtual void StopRendering() = 0;
+ // Sets the media time to start rendering from. Only valid to call while not
+ // currently .rendering.
xhwang 2014/07/18 04:56:44 remove extra dot
scherkus (not reviewing) 2014/07/18 15:29:30 Done.
+ //
+ // TODO(scherkus): Fold into TimeSource API.
+ virtual void SetMediaTime(base::TimeDelta time) = 0;
+
// Discard any audio data, executing |callback| when completed.
//
// Clients should expect |buffering_state_cb| to be called with
@@ -61,10 +71,9 @@ class MEDIA_EXPORT AudioRenderer {
virtual void Flush(const base::Closure& callback) = 0;
// Starts playback by reading from |stream| and decoding and rendering audio.
- // |timestamp| is the media timestamp playback should start rendering from.
//
// Only valid to call after a successful Initialize() or Flush().
- virtual void StartPlayingFrom(base::TimeDelta timestamp) = 0;
+ virtual void StartPlaying() = 0;
// Stop all operations in preparation for being deleted, executing |callback|
// when complete.
« no previous file with comments | « no previous file | media/base/mock_filters.h » ('j') | media/filters/audio_renderer_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698