Clean up Bluetooth API implementation.

Clean up Bluetooth API implementation.

* Remove some deprecated methods.
* Make DoWork a void function, rather than having an unused bool return value.

BUG=none
TEST=none
R=armansito@chromium.org, keybuk@chromium.org

[keybuk, 2014-07-18 00:33:36]

lgtm

[Ilya Sherman, 2014-07-18 00:46:00]

The CQ bit was checked by isherman@chromium.org

[Ilya Sherman, 2014-07-18 00:46:05]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-07-18 00:47:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/isherman@chromium.org/400843002/20001

[armansito, 2014-07-18 03:26:37]

https://codereview.chromium.org/400843002/diff/20001/chrome/browser/extension...
File
chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc
(left):

https://codereview.chromium.org/400843002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc:72:

Does this code actually compile? The reason these functions return bool is
because of the expression the EXTENSION_FUNCTION_VALIDATE macro expands to.

The correct way to clean this up would be to follow the example of
BluetoothSocketApi and do something similar to AsyncExtensionFunction. This is
on my list but it's not that urgent.

[commit-bot: I haz the power, 2014-07-18 04:55:26]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/30155)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/34570)

[commit-bot: I haz the power, 2014-07-18 04:59:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-18 04:59:42]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Ilya Sherman, 2014-07-18 21:37:00]

https://codereview.chromium.org/400843002/diff/20001/chrome/browser/extension...
File
chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc
(left):

https://codereview.chromium.org/400843002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc:72:

On 2014/07/18 03:26:37, armansito wrote:
> Does this code actually compile? The reason these functions return bool is
> because of the expression the EXTENSION_FUNCTION_VALIDATE macro expands to.
> 
> The correct way to clean this up would be to follow the example of
> BluetoothSocketApi and do something similar to AsyncExtensionFunction. This is
> on my list but it's not that urgent.

Oh, wow: EXTENSION_FUNCTION_VALIDATE returns a value in release builds, but does
nothing of the sort in debug builds.  So, this compiled for me locally, despite
the error.  Gotta love preprocessor macros...

Anyway, abandoning this CL.  Thanks for catching that.

[armansito, 2014-07-18 21:40:54]

On 2014/07/18 21:37:00, Ilya Sherman wrote:
>
https://codereview.chromium.org/400843002/diff/20001/chrome/browser/extension...
> File
> chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc
> (left):
> 
>
https://codereview.chromium.org/400843002/diff/20001/chrome/browser/extension...
>
chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc:72:
> 
> On 2014/07/18 03:26:37, armansito wrote:
> > Does this code actually compile? The reason these functions return bool is
> > because of the expression the EXTENSION_FUNCTION_VALIDATE macro expands to.
> > 
> > The correct way to clean this up would be to follow the example of
> > BluetoothSocketApi and do something similar to AsyncExtensionFunction. This
is
> > on my list but it's not that urgent.
> 
> Oh, wow: EXTENSION_FUNCTION_VALIDATE returns a value in release builds, but
does
> nothing of the sort in debug builds.  So, this compiled for me locally,
despite
> the error.  Gotta love preprocessor macros...
> 
> Anyway, abandoning this CL.  Thanks for catching that.

Yeah, I ran into this same issue when writing the code for
chrome.bluetoothLowEnergy, though I decided to just return bool from DoWork
since the chrome.bluetooth code also did that :) I guess we should refactor
things later so that these function implementations have a Prepare function that
returns bool and performs the EXTENSION_FUNCTION_VALIDATE check, like
AsyncExtensionFunction does, so that DoWork doesn't have to return a value.