Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 400823004: gin (Closed)

Created:
6 years, 5 months ago by raymes
Modified:
5 years, 10 months ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen (gone - plz use gerrit)
Project:
chromium
Visibility:
Public.

Description

gin BUG=

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Total comments: 2

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1564 lines, -2075 lines) Patch
M content/content_renderer.gypi View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/pepper/host_var_tracker.h View 1 2 3 4 2 chunks +30 lines, -32 lines 0 comments Download
M content/renderer/pepper/host_var_tracker.cc View 1 2 3 4 5 6 4 chunks +82 lines, -74 lines 0 comments Download
M content/renderer/pepper/host_var_tracker_unittest.cc View 1 2 3 4 5 6 7 8 2 chunks +57 lines, -51 lines 0 comments Download
M content/renderer/pepper/message_channel.h View 1 2 3 4 5 chunks +73 lines, -52 lines 0 comments Download
M content/renderer/pepper/message_channel.cc View 1 2 3 6 chunks +242 lines, -378 lines 0 comments Download
D content/renderer/pepper/npapi_glue.h View 1 chunk +0 lines, -262 lines 0 comments Download
D content/renderer/pepper/npapi_glue.cc View 1 chunk +0 lines, -358 lines 0 comments Download
D content/renderer/pepper/npobject_var.h View 1 chunk +0 lines, -71 lines 0 comments Download
D content/renderer/pepper/npobject_var.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.h View 1 2 3 8 chunks +10 lines, -12 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 2 3 14 chunks +66 lines, -60 lines 0 comments Download
A content/renderer/pepper/pepper_try_catch.h View 1 2 3 4 5 6 1 chunk +92 lines, -0 lines 0 comments Download
A content/renderer/pepper/pepper_try_catch.cc View 1 2 3 4 5 6 7 8 1 chunk +149 lines, -0 lines 0 comments Download
M content/renderer/pepper/pepper_webplugin_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_webplugin_impl.cc View 1 2 3 3 chunks +16 lines, -14 lines 0 comments Download
M content/renderer/pepper/plugin_module.cc View 1 2 3 4 1 chunk +6 lines, -1 line 0 comments Download
M content/renderer/pepper/plugin_object.h View 1 2 3 4 2 chunks +59 lines, -46 lines 0 comments Download
M content/renderer/pepper/plugin_object.cc View 1 2 3 4 5 3 chunks +214 lines, -294 lines 0 comments Download
M content/renderer/pepper/ppb_var_deprecated_impl.cc View 1 2 3 4 5 6 7 8 2 chunks +190 lines, -262 lines 0 comments Download
M content/renderer/pepper/v8_var_converter.h View 2 chunks +7 lines, -0 lines 0 comments Download
M content/renderer/pepper/v8_var_converter.cc View 1 2 14 chunks +46 lines, -7 lines 0 comments Download
A + content/renderer/pepper/v8object_var.h View 1 2 3 4 1 chunk +22 lines, -26 lines 0 comments Download
A content/renderer/pepper/v8object_var.cc View 1 2 3 4 1 chunk +64 lines, -0 lines 0 comments Download
M content/test/ppapi/ppapi_test.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M ppapi/api/private/ppb_testing_private.idl View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M ppapi/c/private/ppb_testing_private.h View 1 2 3 4 2 chunks +5 lines, -1 line 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 1 2 3 4 2 chunks +7 lines, -1 line 0 comments Download
M ppapi/proxy/ppb_testing_proxy.cc View 1 2 3 4 2 chunks +7 lines, -1 line 0 comments Download
M ppapi/proxy/ppp_instance_private_proxy_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ppapi/shared_impl/scoped_pp_var.h View 2 chunks +37 lines, -0 lines 0 comments Download
M ppapi/shared_impl/scoped_pp_var.cc View 2 chunks +40 lines, -0 lines 0 comments Download
M ppapi/shared_impl/var.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/shared_impl/var.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_case.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/tests/test_instance_deprecated.cc View 1 2 3 4 4 chunks +19 lines, -4 lines 0 comments Download
M ppapi/tests/test_var_deprecated.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Krzysztof Olczyk
https://codereview.chromium.org/400823004/diff/140001/content/renderer/pepper/message_channel.cc File content/renderer/pepper/message_channel.cc (right): https://codereview.chromium.org/400823004/diff/140001/content/renderer/pepper/message_channel.cc#newcode277 content/renderer/pepper/message_channel.cc:277: void MessageChannel::PostMessageToNative(gin::Arguments* args) { If I'm not wrong, you ...
6 years, 4 months ago (2014-07-31 07:12:57 UTC) #1
raymes
6 years, 4 months ago (2014-07-31 07:18:50 UTC) #2 
Cool, thanks :) Once you land your patch I'll rebase on it.

On Thu, Jul 31, 2014 at 5:12 PM,  <kolczyk@opera.com> wrote:
>
>
https://codereview.chromium.org/400823004/diff/140001/content/renderer/pepper...
> File content/renderer/pepper/message_channel.cc (right):
>
>
https://codereview.chromium.org/400823004/diff/140001/content/renderer/pepper...
> content/renderer/pepper/message_channel.cc:277: void
> MessageChannel::PostMessageToNative(gin::Arguments* args) {
> If I'm not wrong, you could accept single argument of
> v8::Handle<v8::Value> and have gin verify one argument was passed for
> you.
>
>
https://codereview.chromium.org/400823004/diff/140001/content/renderer/pepper...
> File content/renderer/pepper/pepper_webplugin_impl.h (right):
>
>
https://codereview.chromium.org/400823004/diff/140001/content/renderer/pepper...
> content/renderer/pepper/pepper_webplugin_impl.h:44: virtual bool
> getScriptableObject(v8::Isolate* isolate,
> You will need to update it, as based on suggestions in review of
> https://codereview.chromium.org/230813002/, I've changed this function
> to return the handle instead of returning it by ptr. (To better match v8
> usage idiom).
>
> https://codereview.chromium.org/400823004/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698