Issue 4008: In release, disable UNREACHABLE and make UNIMPLEMENTED and FATAL simpler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4008: In release, disable UNREACHABLE and make UNIMPLEMENTED and FATAL simpler. (Closed)

Created:
12 years, 3 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
iposva, bak, Kasper Lund

CC:
v8-dev

Visibility:
Public.

Description

In release, disable UNREACHABLE and make UNIMPLEMENTED and FATAL simpler, removing the file name and line numbers, so we carry around less data and can share more code.

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	src/checks.h	View		1 chunk	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

I am up for debate on this. UNIMPLEMENTED and FATAL aren't used that much, so ...

12 years, 3 months ago (2008-09-20 17:24:18 UTC) #1

iposva

12 years, 3 months ago (2008-09-22 13:41:56 UTC) #2

I do like the UNREACHABLE because it signals that something went really wrong.
But I am not sure if it is more useful than an ASSERT.

I do like Kasper's suggestion to simplifying the UNIMPLEMENTED call's
implementation.

Expand Messages | Collapse Messages