Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 400793002: Makes embedded content shell build without pango (Closed)

Created:
6 years, 5 months ago by varkha
Modified:
6 years, 5 months ago
Reviewers:
tony, spang
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Makes embedded content shell build without pango BUG=178543 TEST=build embedded content shell with chromeos=1 and embedded=1 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284759

Patch Set 1 #

Total comments: 2

Patch Set 2 : Makes embedded content shell build without pango #

Patch Set 3 : Makes embedded content shell build without pango (fixed env variable) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M build/common.gypi View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (0 generated)
varkha
spang@, can you please take a look?
6 years, 5 months ago (2014-07-17 18:48:54 UTC) #1
spang
https://codereview.chromium.org/400793002/diff/1/ui/base/resource/resource_bundle.cc File ui/base/resource/resource_bundle.cc (right): https://codereview.chromium.org/400793002/diff/1/ui/base/resource/resource_bundle.cc#newcode71 ui/base/resource/resource_bundle.cc:71: #if defined(OS_CHROMEOS) && (!defined(USE_OZONE) || defined(USE_PANGO)) you don't need ...
6 years, 5 months ago (2014-07-17 18:53:44 UTC) #2
varkha
https://codereview.chromium.org/400793002/diff/1/ui/base/resource/resource_bundle.cc File ui/base/resource/resource_bundle.cc (right): https://codereview.chromium.org/400793002/diff/1/ui/base/resource/resource_bundle.cc#newcode71 ui/base/resource/resource_bundle.cc:71: #if defined(OS_CHROMEOS) && (!defined(USE_OZONE) || defined(USE_PANGO)) On 2014/07/17 18:53:44, ...
6 years, 5 months ago (2014-07-17 18:57:48 UTC) #3
spang
+tony lgtm
6 years, 5 months ago (2014-07-17 18:59:53 UTC) #4
tony
lgtm
6 years, 5 months ago (2014-07-17 19:45:40 UTC) #5
varkha
The CQ bit was checked by varkha@chromium.org
6 years, 5 months ago (2014-07-17 19:48:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/400793002/20001
6 years, 5 months ago (2014-07-17 19:54:57 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-19 02:06:49 UTC) #8
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 5 months ago (2014-07-19 02:06:50 UTC) #9
varkha
The CQ bit was checked by varkha@chromium.org
6 years, 5 months ago (2014-07-19 02:11:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/400793002/20001
6 years, 5 months ago (2014-07-19 02:12:52 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-20 14:14:13 UTC) #12
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 5 months ago (2014-07-20 14:14:14 UTC) #13
varkha
The CQ bit was checked by varkha@chromium.org
6 years, 5 months ago (2014-07-20 14:49:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/400793002/20001
6 years, 5 months ago (2014-07-20 14:50:25 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 02:52:01 UTC) #16
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 5 months ago (2014-07-22 02:52:02 UTC) #17
varkha
The CQ bit was checked by varkha@chromium.org
6 years, 5 months ago (2014-07-22 16:49:05 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/400793002/40001
6 years, 5 months ago (2014-07-22 16:49:51 UTC) #19
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 19:50:52 UTC) #20
Message was sent while issue was closed. 
Change committed as 284759

Powered by Google App Engine
This is Rietveld 408576698