Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 400773002: cc: Parameterize the main thread task runner (Closed)

Created:
6 years, 5 months ago by Sami
Modified:
6 years, 5 months ago
Reviewers:
danakj, jam, boliu, qsr, ccameron
CC:
chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, danakj+watch_chromium.org, viettrungluu+watch_chromium.org, Ian Vollick, yzshen+watch_chromium.org, abarth-chromium, jbauman+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, sievers+watch_chromium.org, ben+mojo_chromium.org, android-webview-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

cc: Parameterize the main thread task runner Make it possible for clients pass in a custom task runner to be used for posting compositor related work onto the main thread. This will be used for prioritizing compositor tasks by the Blink scheduler. Covered by existing tests. BUG=391005 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284103

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove mistakenly added decl. #

Total comments: 2

Patch Set 3 : Rebased. #

Patch Set 4 : WebView fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -68 lines) Patch
M android_webview/browser/hardware_renderer.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/layer_perftest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/layers/layer_unittest.cc View 2 chunks +12 lines, -7 lines 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/texture_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/tiled_layer_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/layers/ui_resource_layer_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/fake_impl_proxy.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/fake_proxy.h View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/test/layer_tree_test.cc View 5 chunks +12 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 2 3 chunks +14 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 4 chunks +24 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_no_message_loop.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_scroll.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/proxy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/proxy.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 2 chunks +6 lines, -3 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 chunk +9 lines, -5 lines 0 comments Download
M cc/trees/thread_proxy.h View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/trees/thread_proxy.cc View 1 2 2 chunks +8 lines, -4 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +5 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/examples/compositor_app/compositor_host.cc View 1 chunk +5 lines, -1 line 0 comments Download
M ui/compositor/compositor.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Sami
Hi Dana, could I get your reaction to this? Here's the overall design doc: https://docs.google.com/a/chromium.org/document/d/11N2WTV3M0IkZ-kQlKWlBcwkOkKTCuLXGVNylK5E2zvc/edit ...
6 years, 5 months ago (2014-07-17 17:55:48 UTC) #1
danakj
LGTM https://codereview.chromium.org/400773002/diff/1/cc/trees/layer_tree_host.h File cc/trees/layer_tree_host.h (right): https://codereview.chromium.org/400773002/diff/1/cc/trees/layer_tree_host.h#newcode103 cc/trees/layer_tree_host.h:103: void ScheduleBeginMainFrameOnImplThread( This looks like it shouldn't be ...
6 years, 5 months ago (2014-07-17 18:00:24 UTC) #2
Sami
Thanks! Adding some owners: boliu@: android_webview/ qsr@: mojo/ jam@: content/ PTAL. https://codereview.chromium.org/400773002/diff/1/cc/trees/layer_tree_host.h File cc/trees/layer_tree_host.h (right): ...
6 years, 5 months ago (2014-07-17 18:48:57 UTC) #3
boliu
https://codereview.chromium.org/400773002/diff/20001/android_webview/browser/hardware_renderer.cc File android_webview/browser/hardware_renderer.cc (right): https://codereview.chromium.org/400773002/diff/20001/android_webview/browser/hardware_renderer.cc#newcode95 android_webview/browser/hardware_renderer.cc:95: this, this, NULL, settings, base::MessageLoopProxy::current()); I think this can ...
6 years, 5 months ago (2014-07-17 18:58:30 UTC) #4
jam
lgtm
6 years, 5 months ago (2014-07-17 20:26:23 UTC) #5
qsr
mojo, LGTM
6 years, 5 months ago (2014-07-18 09:38:24 UTC) #6
Sami
https://codereview.chromium.org/400773002/diff/20001/android_webview/browser/hardware_renderer.cc File android_webview/browser/hardware_renderer.cc (right): https://codereview.chromium.org/400773002/diff/20001/android_webview/browser/hardware_renderer.cc#newcode95 android_webview/browser/hardware_renderer.cc:95: this, this, NULL, settings, base::MessageLoopProxy::current()); On 2014/07/17 18:58:29, boliu ...
6 years, 5 months ago (2014-07-18 10:54:11 UTC) #7
boliu
lgtm
6 years, 5 months ago (2014-07-18 13:58:27 UTC) #8
Sami
The CQ bit was checked by skyostil@chromium.org
6 years, 5 months ago (2014-07-18 14:09:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/400773002/60001
6 years, 5 months ago (2014-07-18 14:10:33 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win8_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 15:07:42 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 15:51:32 UTC) #12
Message was sent while issue was closed. 
Change committed as 284103

Powered by Google App Engine
This is Rietveld 408576698