LayoutTests/fast/dom/relList_on_anchor.html - Issue 400763002: Adding relList attr to link and anchor element

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/relList_on_anchor.html

Issue 400763002: Adding relList attr to link and anchor element Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: modified as per review comment Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <a id="anchorId" rel="shortcut icon" href="../images/resources/1bit.ico"/>
	Inactive 2014/07/25 12:55:51 Please add back the DOCTYPE. Please add back the DOCTYPE.
	2 <script src="../../resources/js-test.js"></script>

	3 <script>

	4 description("Checks relList attribute on anchor element");

	5

	6 var anchor = document.getElementById('anchorId');

	7 shouldBe("anchor.relList.__proto__", "DOMTokenList.prototype");

	8 shouldBeTrue("anchor.relList.contains('shortcut')");
	Inactive 2014/07/25 12:55:51 The issue with contains() is that you don't verify The issue with contains() is that you don't verify that the value is at the expected index. How about using: shouldBeEqualToString("anchor.relList[0]", "shortcut");
	9 shouldBeTrue("anchor.relList.contains('icon')");

	10 shouldBe("anchor.relList.length", "2");

	11 shouldBeFalse("anchor.relList.contains('shortcut1')");

	12 shouldNotThrow("anchor.rel = 'nofollow'");

	13 shouldBe("anchor.relList.length", "1");

	14 shouldBeTrue("anchor.relList.contains('nofollow')");

	15 shouldBeFalse("anchor.relList.contains('shortcut')");

	16 shouldBeFalse("anchor.relList.contains('icon')");

	17 shouldNotThrow("anchor.removeAttribute('rel')");

	18 shouldBeEmptyString("anchor.rel");

	19 shouldBe("anchor.relList.length", "0");

	20 shouldBeUndefined("anchor.relList[0]");

	21 </script>

OLD	NEW