LayoutTests/fast/dom/relList_on_anchor.html - Issue 400763002: Adding relList attr to link and anchor element

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/relList_on_anchor.html

Issue 400763002: Adding relList attr to link and anchor element Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added to relList to anchor element and LayoutTest Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>
	Inactive 2014/07/24 15:36:40 We don't really need <html> / <head> or <body> her We don't really need <html> / <head> or <body> here. You can omit them.
	3 <head>

	4 <a rel="shortcut icon" href="../images/resources/1bit.ico"/>

	5 <script src="../../resources/js-test.js"></script>

	6 </head>

	7 <body>

	8 <script>

	9 description("Checks relList attribute on anchor element");

	10

	11 var anchorrellist = document.querySelectorAll('a[rel]');
	Inactive 2014/07/24 15:36:40 Just add an id to your element and do a getElement Just add an id to your element and do a getElementById(), this is more efficient and simpler.
	12 var anchor = anchorrellist[0];
	Inactive 2014/07/24 15:36:40 Could you add the following check? shouldBe("anch Could you add the following check? shouldBe("anchor.relList.__proto__", "DOMTokenList.prototype");
	13 shouldBe("anchor.relList.contains('shortcut')", "true");
	Inactive 2014/07/24 15:36:40 Use shouldBeTrue() and shouldBeFalse() as needed. Use shouldBeTrue() and shouldBeFalse() as needed.
	14 shouldBe("anchor.relList.contains('icon')", "true");
	Inactive 2014/07/24 15:36:40 It would be nice to check the indexed getters as w It would be nice to check the indexed getters as well (i.e. anchor.relList[0])
	15 shouldBe("anchor.relList.length", "2");

	16 shouldBe("anchor.relList.contains('shortcut1')", "false");

	17 shouldNotThrow("anchor.rel = 'nofollow'");

	18 shouldBe("anchor.relList.length", "1");

	19 shouldBe("anchor.relList.contains('nofollow')", "true");

	20 shouldBe("anchor.relList.contains('shortcut')", "false");

	21 shouldBe("anchor.relList.contains('icon')", "false");

	22 </script>
	Inactive 2014/07/24 15:36:40 Could you also try to remove the rel attribute and Could you also try to remove the rel attribute and check relList?
	23 </body>

	24 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/relList_on_anchor-expected.txt » ('j') | LayoutTests/fast/dom/relList_on_link.html » ('J')