Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Side by Side Diff: Source/core/html/HTMLLinkElement.cpp

Issue 400763002: Adding relList attr to link and anchor element Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Modified as per review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2003, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed. 5 * Copyright (C) 2003, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed.
6 * Copyright (C) 2009 Rob Buis (rwlbuis@gmail.com) 6 * Copyright (C) 2009 Rob Buis (rwlbuis@gmail.com)
7 * Copyright (C) 2011 Google Inc. All rights reserved. 7 * Copyright (C) 2011 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 403 matching lines...) Expand 10 before | Expand all | Expand 10 after
414 KURL HTMLLinkElement::href() const 414 KURL HTMLLinkElement::href() const
415 { 415 {
416 return document().completeURL(getAttribute(hrefAttr)); 416 return document().completeURL(getAttribute(hrefAttr));
417 } 417 }
418 418
419 const AtomicString& HTMLLinkElement::rel() const 419 const AtomicString& HTMLLinkElement::rel() const
420 { 420 {
421 return getAttribute(relAttr); 421 return getAttribute(relAttr);
422 } 422 }
423 423
424 DOMTokenList& HTMLLinkElement::relList()
425 {
426 if (!m_relList)
427 setRelList(RelList::create(this));
Inactive 2014/07/23 13:26:43 m_relList = RelList::create(this);
428 return *m_relList.get();
Inactive 2014/07/23 13:26:43 .get() is unnecessary
429 }
430
424 const AtomicString& HTMLLinkElement::type() const 431 const AtomicString& HTMLLinkElement::type() const
425 { 432 {
426 return getAttribute(typeAttr); 433 return getAttribute(typeAttr);
427 } 434 }
428 435
429 bool HTMLLinkElement::async() const 436 bool HTMLLinkElement::async() const
430 { 437 {
431 return fastHasAttribute(HTMLNames::asyncAttr); 438 return fastHasAttribute(HTMLNames::asyncAttr);
432 } 439 }
433 440
(...skipping 25 matching lines...) Expand all
459 V8DOMActivityLogger* activityLogger = V8DOMActivityLogger::currentActivi tyLoggerIfIsolatedWorld(); 466 V8DOMActivityLogger* activityLogger = V8DOMActivityLogger::currentActivi tyLoggerIfIsolatedWorld();
460 if (activityLogger) { 467 if (activityLogger) {
461 Vector<String> argv; 468 Vector<String> argv;
462 argv.append("link"); 469 argv.append("link");
463 argv.append(hrefAttr.toString()); 470 argv.append(hrefAttr.toString());
464 argv.append(oldValue); 471 argv.append(oldValue);
465 argv.append(newValue); 472 argv.append(newValue);
466 activityLogger->logEvent("blinkSetAttribute", argv.size(), argv.data ()); 473 activityLogger->logEvent("blinkSetAttribute", argv.size(), argv.data ());
467 } 474 }
468 } 475 }
476
477 if (name == relAttr && m_relList)
Inactive 2014/07/23 13:26:43 I would do this in HTMLLinkElement::parseAttribute
478 m_relList->setValue(newValue);
479
469 HTMLElement::attributeWillChange(name, oldValue, newValue); 480 HTMLElement::attributeWillChange(name, oldValue, newValue);
470 } 481 }
471 482
472 PassOwnPtrWillBeRawPtr<LinkStyle> LinkStyle::create(HTMLLinkElement* owner) 483 PassOwnPtrWillBeRawPtr<LinkStyle> LinkStyle::create(HTMLLinkElement* owner)
473 { 484 {
474 return adoptPtrWillBeNoop(new LinkStyle(owner)); 485 return adoptPtrWillBeNoop(new LinkStyle(owner));
475 } 486 }
476 487
477 LinkStyle::LinkStyle(HTMLLinkElement* owner) 488 LinkStyle::LinkStyle(HTMLLinkElement* owner)
478 : LinkResource(owner) 489 : LinkResource(owner)
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
741 removePendingSheet(); 752 removePendingSheet();
742 } 753 }
743 754
744 void LinkStyle::trace(Visitor* visitor) 755 void LinkStyle::trace(Visitor* visitor)
745 { 756 {
746 visitor->trace(m_sheet); 757 visitor->trace(m_sheet);
747 LinkResource::trace(visitor); 758 LinkResource::trace(visitor);
748 } 759 }
749 760
750 } // namespace WebCore 761 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698