Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 400753002: cc: Add layer raster tile iterator construct perftest (Closed)

Created:
6 years, 5 months ago by vmpstr
Modified:
6 years, 5 months ago
Reviewers:
reveman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Add layer raster tile iterator construct perftest This patch adds a layer level raster tile perftest to measure how expensive is it to create a layer raster tile iterator. Initial run: [ RUN ] PictureLayerImplPerfTest.LayerRasterTileIteratorConstructAndIterate *RESULT layer_raster_tile_iterator_construct_and_iterate: 32_100x100= 389462.09375 runs/s *RESULT layer_raster_tile_iterator_construct_and_iterate: 32_500x500= 392804.6875 runs/s *RESULT layer_raster_tile_iterator_construct_and_iterate: 64_100x100= 230574.3125 runs/s *RESULT layer_raster_tile_iterator_construct_and_iterate: 64_500x500= 230933.953125 runs/s [ OK ] PictureLayerImplPerfTest.LayerRasterTileIteratorConstructAndIterate (8408 ms) [ RUN ] PictureLayerImplPerfTest.LayerRasterTileIteratorConstruct *RESULT layer_raster_tile_iterator_construct: 0_0_100x100= 2187284 runs/s *RESULT layer_raster_tile_iterator_construct: 5000_0_100x100= 1882842.125 runs/s *RESULT layer_raster_tile_iterator_construct: 9999_0_100x100= 2171275 runs/s [ OK ] PictureLayerImplPerfTest.LayerRasterTileIteratorConstruct (7619 ms) NOTE TO PERF SHERIFFS --------------------- This patch replaces layer_raster_tile_iterator test with layer_raster_tile_iterator_construct_and_iterate test. R=reveman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284105

Patch Set 1 #

Patch Set 2 : removed useless assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -13 lines) Patch
M cc/layers/picture_layer_impl_perftest.cc View 1 3 chunks +57 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
vmpstr
PTAL
6 years, 5 months ago (2014-07-17 17:09:46 UTC) #1
reveman
lgtm
6 years, 5 months ago (2014-07-17 17:52:20 UTC) #2
vmpstr
The CQ bit was checked by vmpstr@chromium.org
6 years, 5 months ago (2014-07-17 18:30:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/400753002/20001
6 years, 5 months ago (2014-07-17 18:33:43 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 22:03:42 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 22:25:48 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/172129)
6 years, 5 months ago (2014-07-17 22:25:49 UTC) #7
vmpstr
The CQ bit was checked by vmpstr@chromium.org
6 years, 5 months ago (2014-07-18 15:54:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/400753002/20001
6 years, 5 months ago (2014-07-18 15:55:47 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 16:02:42 UTC) #10
Message was sent while issue was closed.
Change committed as 284105

Powered by Google App Engine
This is Rietveld 408576698