Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 400743002: MIPS: StubCallInterfaceDescriptor and CallInterfaceDescriptor are unified under a base class Interf… (Closed)

Created:
6 years, 5 months ago by balazs.kilvady
Modified:
6 years, 5 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

MIPS: StubCallInterfaceDescriptor and CallInterfaceDescriptor are unified under a base class InterfaceDescriptor. Port r22448 (a9e0b0e) Original commit message: Handling of the context register had to be massaged to effect the unification. This will make it easier to call hydrogen code stubs directly from crankshaft. BUG= R=mvstanton@chromium.org, paul.lind@imgtec.com Committed: https://code.google.com/p/v8/source/detail?r=22456

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -72 lines) Patch
M src/mips/code-stubs-mips.cc View 19 chunks +38 lines, -29 lines 0 comments Download
M src/mips/lithium-mips.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/mips/lithium-mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 19 chunks +37 lines, -29 lines 0 comments Download
M src/mips64/lithium-mips64.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/mips64/lithium-mips64.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
balazs.kilvady
6 years, 5 months ago (2014-07-17 17:08:09 UTC) #1
mvstanton
lgtm
6 years, 5 months ago (2014-07-17 18:13:12 UTC) #2
paul.l...
also lgtm.
6 years, 5 months ago (2014-07-17 18:15:47 UTC) #3
balazs.kilvady
6 years, 5 months ago (2014-07-17 18:25:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r22456 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698