Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 400713002: mojo: Fix running mojo_demo_launcher with chromeos=1. (Closed)

Created:
6 years, 5 months ago by sadrul
Modified:
6 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

mojo: Fix running mojo_demo_launcher with chromeos=1. Initialize the input-method using ui::InitializeInputMethodForTesting() before creating the input method. BUG=none R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283874

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M mojo/views/native_widget_view_manager.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sadrul
6 years, 5 months ago (2014-07-17 15:49:13 UTC) #1
sky
LGTM
6 years, 5 months ago (2014-07-17 16:00:42 UTC) #2
sadrul
6 years, 5 months ago (2014-07-17 21:14:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r283874 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698