Ensure that the callback for MetadataCache.getOne() is called asynchronously.

Ensure that the callback for MetadataCache.getOne() is called asynchronously.

BUG=394788
TEST=manually tested

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284053

[fukino, 2014-07-17 16:08:48]

yoshiki san, could you take a look? Thanks!

[yoshiki, 2014-07-18 05:42:09]

Could you make sure that this 'callback' must be called  asynchronously in any
call-paths? And please add a comment like "This is called asynchronously." to
the description of "callback" parameter.

[fukino, 2014-07-18 06:28:12]

Thanks for comments! PTAL at new patch set.

https://codereview.chromium.org/400703002/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js
(right):

https://codereview.chromium.org/400703002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js:205:
this.getInternal_(entries, type, false, callback);
As this.getInternal_ doesn't have any return value, I omitted 'return'.

https://codereview.chromium.org/400703002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js:247: if
(callback) callback(result);
Now that the getOneInternal_ is asynchronous, setTimeout for this part is not
necessary.

https://codereview.chromium.org/400703002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js:1006:
setTimeout(callback.bind(null, {}), 0);
I overlooked this path. Thanks!

[yoshiki, 2014-07-18 06:32:32]

lgt with nit. Thanks!

https://codereview.chromium.org/400703002/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js
(right):

https://codereview.chromium.org/400703002/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js:1001:
callback({});
This is called synchronously.

https://codereview.chromium.org/400703002/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js
(right):

https://codereview.chromium.org/400703002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js:261: *
Fetches the metadata for one Entry. See comments to |get|.
nit: please add a blank line, since the comment gets longer.

[yoshiki, 2014-07-18 06:32:56]

https://codereview.chromium.org/400703002/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js
(right):

https://codereview.chromium.org/400703002/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js:1001:
callback({});
On 2014/07/18 06:32:32, yoshiki wrote:
> This is called synchronously. 

Sorry, this comment is wrong. Please ignore this.

[yoshiki, 2014-07-18 06:33:15]

lgtm with nit

[fukino, 2014-07-18 06:48:06]

Thanks!

https://codereview.chromium.org/400703002/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js
(right):

https://codereview.chromium.org/400703002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js:261: *
Fetches the metadata for one Entry. See comments to |get|.
On 2014/07/18 06:32:32, yoshiki wrote:
> nit: please add a blank line, since the comment gets longer.

Done.

[fukino, 2014-07-18 06:48:13]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2014-07-18 06:49:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fukino@chromium.org/400703002/40001

[commit-bot: I haz the power, 2014-07-18 08:51:15]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-18 10:52:30]

Change committed as 284053