Issue 4007: Cleanup EOL and include guards. Lack of EOL on bloom_filter.h had broken the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4007: Cleanup EOL and include guards. Lack of EOL on bloom_filter.h had broken the... (Closed)

Created:
12 years, 3 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
paulg, M-A Ruel

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Cleanup EOL and include guards, including fixing one guard that was not the correct path. Lack of EOL on bloom_filter.h had broken the Linux build, this is a fatal warning with GCC. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2437

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -38 lines)			Patch
M	chrome/browser/safe_browsing/bloom_filter.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/safe_browsing/bloom_filter.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/safe_browsing/bloom_filter_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/safe_browsing/chunk_range.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/safe_browsing/protocol_manager.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/safe_browsing/protocol_manager.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/safe_browsing/protocol_parser.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_blocking_page.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_blocking_page.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_database.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_database_impl.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_database_impl.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_database_impl_unittest.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_database_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_service.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_util.h	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_util.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages