Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 400693003: Fix the bounds of the extension action overflow menu (Closed)

Created:
6 years, 5 months ago by Devlin
Modified:
6 years, 5 months ago
Reviewers:
Finnur, Peter Kasting
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix the bounds of the extension action overflow menu The bounds of the ExtensionToolbarMenuView were different than that of the contained BrowserActionsContainer, so part of the BrowserActionsContainer was cut off. Fix this by setting the bounds of the MenuView to match those of the Container. Before: http://imgur.com/15oiD3G,04VAifx#0 After: http://imgur.com/15oiD3G,04VAifx#1 Blue is the ExtensionToolbarMenuView, Red is the BrowserActionsContainer. In the before, note that Browser Action VIII is missing (cut off). BUG=391280 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283932

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Devlin
Finnur and Peter, mind taking a quick look?
6 years, 5 months ago (2014-07-17 16:07:38 UTC) #1
Finnur
LGTM
6 years, 5 months ago (2014-07-17 16:09:53 UTC) #2
Peter Kasting
LGTM
6 years, 5 months ago (2014-07-17 17:54:49 UTC) #3
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 5 months ago (2014-07-17 18:00:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/400693003/1
6 years, 5 months ago (2014-07-17 18:02:17 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 21:06:02 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 22:22:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/172178)
6 years, 5 months ago (2014-07-17 22:22:17 UTC) #8
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 5 months ago (2014-07-17 22:26:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/400693003/1
6 years, 5 months ago (2014-07-17 22:30:49 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 22:51:16 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 23:56:37 UTC) #12
Message was sent while issue was closed.
Change committed as 283932

Powered by Google App Engine
This is Rietveld 408576698