Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 400673002: DevTools: Fix dirty files handling in search across all files. (Closed)

Created:
6 years, 5 months ago by vsevik
Modified:
6 years, 5 months ago
Reviewers:
apavlov, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Fix dirty files handling in search across all files. R=apavlov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178374

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -1 line) Patch
M LayoutTests/http/tests/inspector-enabled/search/sources-search-scope.html View 2 chunks +14 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/inspector-enabled/search/sources-search-scope-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/inspector/search/sources-search-scope-in-files.html View 2 chunks +18 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/inspector/search/sources-search-scope-in-files-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesSearchScope.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
vsevik
PTAL
6 years, 5 months ago (2014-07-17 13:03:13 UTC) #1
yurys
lgtm
6 years, 5 months ago (2014-07-17 13:08:00 UTC) #2
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 5 months ago (2014-07-17 13:13:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/400673002/1
6 years, 5 months ago (2014-07-17 13:14:33 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 14:17:17 UTC) #5
Message was sent while issue was closed.
Change committed as 178374

Powered by Google App Engine
This is Rietveld 408576698