Issue 400653002: Un-wrap long url lines in the supervised user interstitial css.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 400653002: Un-wrap long url lines in the supervised user interstitial css. (Closed)

Created:
6 years, 5 months ago by Marc Treib

Modified:
6 years, 5 months ago

Reviewers:
Pam (message me for reviews)

CC:
chromium-reviews, pam+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Un-wrap long url lines in the supervised user interstitial css. Wrapping them silenty breaks the referenced resources. This was broken in https://codereview.chromium.org/384023002/. dcommitting to bypass the presubmit hooks which refuse the long lines. BUG=385113 R=pam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284057

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	chrome/browser/resources/supervised_user_block_interstitial.css	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

Marc Treib

Hi Pam, PTAL - apparently there's no way to legally break such lines in css?

6 years, 5 months ago (2014-07-17 12:54:04 UTC) #1

Marc Treib

6 years, 5 months ago (2014-07-18 10:57:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r284057 (presubmit successful).