RenderWidgetHost now stores both the WebKeyboardEvent and the native

chrome/common/native_web_keyboard_event_win.cc

+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/common/native_web_keyboard_event.h"
+
+NativeWebKeyboardEvent::NativeWebKeyboardEvent() {
+  actual_message.hwnd = NULL;

[darin (slow to review), 2009/03/06 04:45:35]

memset(&actual_message, 0, sizeof(actual_message));

however, the base class default constructor does nothing, so perhaps this one
should too.  in fact, i'd be surprised if this constructor is ever called.  is
it?  i bet you could make it private forcing people to use the other
constructor.

[Elliot Glaysher, 2009/03/06 20:51:25]

I can't make this private because I use the default constructor for unit
testing, but I can cut out the work.

+  actual_message.message = 0;
+  actual_message.wParam = 0;
+  actual_message.lParam = 0;
+}
+
+NativeWebKeyboardEvent::NativeWebKeyboardEvent(
+    HWND hwnd, UINT message, WPARAM wparam, LPARAM lparam)
+    : WebKeyboardEvent(hwnd, message, wparam, lparam) {
+  actual_message.hwnd = hwnd;
+  actual_message.message = message;
+  actual_message.wParam = wparam;
+  actual_message.lParam = lparam;
+}
+
+NativeWebKeyboardEvent::NativeWebKeyboardEvent(

[darin (slow to review), 2009/03/06 04:45:35]

i don't think there is any reason to implement copy constructors or assignment
operators for OS_WIN.  the defaults should work properly.

[Elliot Glaysher, 2009/03/06 20:51:25]

I feel this is the lesser of two evils compared to the ifdef statements
necessary in the header to supply declare copy constructors/operator=s for some
(but not all) platforms.

+    const NativeWebKeyboardEvent& other)
+    : WebKeyboardEvent(other) {
+  actual_message.hwnd = other.actual_message.hwnd;
+  actual_message.message = other.actual_message.message;
+  actual_message.wParam = other.actual_message.wParam;
+  actual_message.lParam = other.actual_message.lParam;
+}
+
+NativeWebKeyboardEvent& NativeWebKeyboardEvent::operator=(
+    const NativeWebKeyboardEvent& other) {
+  WebKeyboardEvent::operator=(other);
+
+  actual_message.hwnd = other.actual_message.hwnd;
+  actual_message.message = other.actual_message.message;
+  actual_message.wParam = other.actual_message.wParam;
+  actual_message.lParam = other.actual_message.lParam;
+  return *this;
+}
+
+NativeWebKeyboardEvent::~NativeWebKeyboardEvent() {
+  // Noop under windows
+}