Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2127)

Unified Diff: Source/devtools/front_end/timeline/TimelineFrameModel.js

Issue 400643002: DevTools: Add ability to go to paint record and paint profiler in Timeline from layers view. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added annotations. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineFrameModel.js
diff --git a/Source/devtools/front_end/timeline/TimelineFrameModel.js b/Source/devtools/front_end/timeline/TimelineFrameModel.js
index 14df2bd20079ad054c8e64cad3b019e7434a90c5..2c40103164a0deb11b3ed852bcb406faf2fdb2c4 100644
--- a/Source/devtools/front_end/timeline/TimelineFrameModel.js
+++ b/Source/devtools/front_end/timeline/TimelineFrameModel.js
@@ -456,7 +456,7 @@ WebInspector.TracingTimelineFrameModel.prototype = {
return;
if (event.name === eventNames.Paint && event.args["data"]["layerId"] && event.picture) {
/** @type {!WebInspector.LayerPaintEvent} */
- var paintEvent = {layerId: event.args["data"]["layerId"], picture: event.picture, rect: event.layerRect};
+ var paintEvent = {layerId: event.args["data"]["layerId"], picture: event.picture, rect: event.layerRect, traceEvent: event};
this._framePendingCommit.paints.push(paintEvent);
}
@@ -579,7 +579,7 @@ WebInspector.TimelineFrame.prototype = {
}
/**
- * @typedef {!{layerId: string, rect: !Array.<number>, picture: string}}
+ * @typedef {!{layerId: string, rect: !Array.<number>, picture: string, traceEvent: !WebInspector.TracingModel.Event}}
*/
WebInspector.LayerPaintEvent;
« no previous file with comments | « Source/devtools/front_end/timeline/Layers3DView.js ('k') | Source/devtools/front_end/timeline/TimelineLayersView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698