Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1476)

Unified Diff: Source/devtools/front_end/timeline/TimelineLayersView.js

Issue 400643002: DevTools: Add ability to go to paint record and paint profiler in Timeline from layers view. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Small refactoring. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineLayersView.js
diff --git a/Source/devtools/front_end/timeline/TimelineLayersView.js b/Source/devtools/front_end/timeline/TimelineLayersView.js
index c8a907ffd9c7828603339f5d1483cb443c4cf8bb..dec3045855271027c6993ed7932760314e54143f 100644
--- a/Source/devtools/front_end/timeline/TimelineLayersView.js
+++ b/Source/devtools/front_end/timeline/TimelineLayersView.js
@@ -43,6 +43,14 @@ WebInspector.TimelineLayersView.prototype = {
}
},
+ /**
+ * @param {!function(!WebInspector.TracingModel.Event)} callback
+ */
+ setSelectPaintEventCallback: function(callback)
caseq 2014/07/17 13:12:22 I'd rather pass TimelineModeViewDelegate here, it
malch 2014/07/17 15:17:44 Done.
+ {
+ this._layers3DView.setSelectPaintEventCallback(callback);
+ },
+
_update: function()
{
var layerTree;
@@ -80,7 +88,7 @@ WebInspector.TimelineLayersView.prototype = {
snapshot.dispose();
return;
}
- this._paintTiles.push({layerId: paintEvent.layerId, rect: paintEvent.rect, snapshot: snapshot});
+ this._paintTiles.push({layerId: paintEvent.layerId, rect: paintEvent.rect, snapshot: snapshot, traceEvent: paintEvent.traceEvent});
}
/**

Powered by Google App Engine
This is Rietveld 408576698