Issue 400633005: Use LayoutUnit::fromFloatRound for setting scroll values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 400633005: Use LayoutUnit::fromFloatRound for setting scroll values (Closed)

Created:
6 years, 5 months ago by eae

Modified:
6 years, 5 months ago

Reviewers:
leviw_travelin_and_unemployed

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Use LayoutUnit::fromFloatRound for setting scroll values Change Elemenet::setScrollLeft and setScrollTop to use LayoutUnit:: fromFloatRound instead of lroundf. This ensures that no unnecessary type conversion takers place and that the values are clamped properly. R=leviw@chromium.org BUG=393464 TEST=fast/scrolling/scroll-max-value.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178488

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -2 lines)			Patch
A	LayoutTests/fast/scrolling/scroll-max-value.html	View	1 chunk	+65 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/scrolling/scroll-max-value-expected.txt	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	Source/core/dom/Element.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/400633005/1

6 years, 5 months ago (2014-07-18 21:23:12 UTC) #8

Message was sent while issue was closed.

Change committed as 178488

Expand Messages | Collapse Messages