Source/devtools/front_end/components/ExecutionContextSelector.js - Issue 400633003: DevTools: introduce multitarget model listeners

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/components/ExecutionContextSelector.js

Issue 400633003: DevTools: introduce multitarget model listeners (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js ('k') | Source/devtools/front_end/console/ConsoleView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/components/ExecutionContextSelector.js

diff --git a/Source/devtools/front_end/components/ExecutionContextSelector.js b/Source/devtools/front_end/components/ExecutionContextSelector.js

index 1a85cca8dc059a506f8955b483bc0fceeb41a33f..2a3a5b2ef558df4384609da7eeca61841f1f4a2c 100644

--- a/Source/devtools/front_end/components/ExecutionContextSelector.js

+++ b/Source/devtools/front_end/components/ExecutionContextSelector.js

@@ -11,6 +11,9 @@ WebInspector.ExecutionContextSelector = function()

WebInspector.targetManager.observeTargets(this);

WebInspector.context.addFlavorChangeListener(WebInspector.ExecutionContext, this._executionContextChanged, this);

WebInspector.context.addFlavorChangeListener(WebInspector.Target, this._targetChanged, this);

+ WebInspector.targetManager.addModelListener(WebInspector.RuntimeModel, WebInspector.RuntimeModel.Events.ExecutionContextCreated, this._onExecutionContextCreated, this);

+ WebInspector.targetManager.addModelListener(WebInspector.RuntimeModel, WebInspector.RuntimeModel.Events.ExecutionContextDestroyed, this._onExecutionContextDestroyed, this);

}

WebInspector.ExecutionContextSelector.prototype = {

@@ -22,9 +25,6 @@ WebInspector.ExecutionContextSelector.prototype = {

{

if (!WebInspector.context.flavor(WebInspector.Target))

WebInspector.context.setFlavor(WebInspector.Target, target);

- target.runtimeModel.addEventListener(WebInspector.RuntimeModel.Events.ExecutionContextCreated, this._onExecutionContextCreated, this);

- target.runtimeModel.addEventListener(WebInspector.RuntimeModel.Events.ExecutionContextDestroyed, this._onExecutionContextDestroyed, this);

/**

@@ -32,8 +32,6 @@ WebInspector.ExecutionContextSelector.prototype = {

targetRemoved: function(target)

{

- target.runtimeModel.removeEventListener(WebInspector.RuntimeModel.Events.ExecutionContextCreated, this._onExecutionContextCreated, this);

- target.runtimeModel.removeEventListener(WebInspector.RuntimeModel.Events.ExecutionContextDestroyed, this._onExecutionContextDestroyed, this);

var currentExecutionContext = WebInspector.context.flavor(WebInspector.ExecutionContext);

if (currentExecutionContext && currentExecutionContext.target() === target)

this._currentExecutionContextGone();