Source/devtools/front_end/profiler/HeapSnapshotView.js - Issue 400633003: DevTools: introduce multitarget model listeners

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/profiler/HeapSnapshotView.js

Issue 400633003: DevTools: introduce multitarget model listeners (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/profiler/CPUProfileView.js ('k') | Source/devtools/front_end/sdk/CPUProfilerModel.js » ('j') | Source/devtools/front_end/sdk/Target.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/profiler/HeapSnapshotView.js

diff --git a/Source/devtools/front_end/profiler/HeapSnapshotView.js b/Source/devtools/front_end/profiler/HeapSnapshotView.js

index b7f793d7f83a9f74be5e75a18aa4d8af1152898b..32c32f7a7545e3f7f25511621ee00a69cb342b65 100644

--- a/Source/devtools/front_end/profiler/HeapSnapshotView.js

+++ b/Source/devtools/front_end/profiler/HeapSnapshotView.js

@@ -1012,6 +1012,9 @@ WebInspector.HeapSnapshotProfileType = function(id, title)

{

WebInspector.ProfileType.call(this, id || WebInspector.HeapSnapshotProfileType.TypeId, title || WebInspector.UIString("Take Heap Snapshot"));

WebInspector.targetManager.observeTargets(this);

+ WebInspector.targetManager.addModelListener(WebInspector.HeapProfilerModel, WebInspector.HeapProfilerModel.Events.ResetProfiles, this._resetProfiles, this);

+ WebInspector.targetManager.addModelListener(WebInspector.HeapProfilerModel, WebInspector.HeapProfilerModel.Events.AddHeapSnapshotChunk, this._addHeapSnapshotChunk, this);

+ WebInspector.targetManager.addModelListener(WebInspector.HeapProfilerModel, WebInspector.HeapProfilerModel.Events.ReportHeapSnapshotProgress, this._reportHeapSnapshotProgress, this);

}

WebInspector.HeapSnapshotProfileType.TypeId = "HEAP";

@@ -1024,9 +1027,6 @@ WebInspector.HeapSnapshotProfileType.prototype = {

targetAdded: function(target)

{

target.heapProfilerModel.enable();

- target.heapProfilerModel.addEventListener(WebInspector.HeapProfilerModel.Events.ResetProfiles, this._resetProfiles, this);

- target.heapProfilerModel.addEventListener(WebInspector.HeapProfilerModel.Events.AddHeapSnapshotChunk, this._addHeapSnapshotChunk, this);

- target.heapProfilerModel.addEventListener(WebInspector.HeapProfilerModel.Events.ReportHeapSnapshotProgress, this._reportHeapSnapshotProgress, this);

/**

@@ -1034,9 +1034,6 @@ WebInspector.HeapSnapshotProfileType.prototype = {

targetRemoved: function(target)

{

- target.heapProfilerModel.removeEventListener(WebInspector.HeapProfilerModel.Events.ResetProfiles, this._resetProfiles, this);

- target.heapProfilerModel.removeEventListener(WebInspector.HeapProfilerModel.Events.AddHeapSnapshotChunk, this._addHeapSnapshotChunk, this);

- target.heapProfilerModel.removeEventListener(WebInspector.HeapProfilerModel.Events.ReportHeapSnapshotProgress, this._reportHeapSnapshotProgress, this);

/**