Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 400623004: Revert of Resolve screen.orientation.lock() promise with undefined. (Closed)

Created:
6 years, 5 months ago by alancutter (OOO until 2018)
Modified:
6 years, 5 months ago
CC:
blink-reviews, dglazkov+blink, jamesr
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Resolve screen.orientation.lock() promise with undefined. (https://codereview.chromium.org/400703003/) Reason for revert: Chromium unit tests fail to compile with this patch on Windows. http://build.chromium.org/p/chromium.webkit/builders/Win%20Builder/builds/58418 Compilation error: FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\content\renderer\screen_orientation\content_unittests.screen_orientation_dispatcher_unittest.obj.rsp /c ..\..\content\renderer\screen_orientation\screen_orientation_dispatcher_unittest.cc /Foobj\content\renderer\screen_orientation\content_unittests.screen_orientation_dispatcher_unittest.obj /Fdobj\content\content_unittests.cc.pdb c:\b\build\slave\win-latest-rel\build\src\content\renderer\screen_orientation\screen_orientation_dispatcher_unittest.cc(121) :error C2259: 'content::MockLockOrientationCallback' : cannot instantiate abstract class due to following members: 'void blink::WebLockOrientationCallback::onSuccess(void)' : is abstract c:\b\build\slave\win-latest-rel\build\src\third_party\webkit\public\platform\weblockorientationcallback.h(26) : see declaration of 'blink::WebLockOrientationCallback::onSuccess' Original issue's description: > Resolve screen.orientation.lock() promise with undefined. > > This is following the current state of the specification. > > BUG=162827 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178406 TBR=abarth@chromium.org,mvanouwerkerk@chromium.org,mlamouri@chromium.org NOTREECHECKS=true NOTRY=true BUG=162827 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178408

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M Source/modules/screen_orientation/LockOrientationCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/screen_orientation/LockOrientationCallback.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M public/platform/WebLockOrientationCallback.h View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
alancutter (OOO until 2018)
Created Revert of Resolve screen.orientation.lock() promise with undefined.
6 years, 5 months ago (2014-07-18 00:07:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/400623004/1
6 years, 5 months ago (2014-07-18 00:08:12 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 00:08:50 UTC) #3
Message was sent while issue was closed.
Change committed as 178408

Powered by Google App Engine
This is Rietveld 408576698