Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 400623002: Be more picky in triggering enrollment recovery. (Closed)

Created:
6 years, 5 months ago by Thiemo Nagel
Modified:
6 years, 5 months ago
Reviewers:
pastarmovj
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Be more picky in triggering enrollment recovery. Restrict triggering of enrollment recovery to a smaller subset of DeviceSettingsService status codes just to be on the safe side. BUG=389481 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284083

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Julian's comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -25 lines) Patch
M chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc View 1 2 chunks +37 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Thiemo Nagel
Hi Julian, could you please take a look? I don't think this has great practical ...
6 years, 5 months ago (2014-07-17 11:57:36 UTC) #1
pastarmovj
LGTM after the adjustment has been made as discussed. https://codereview.chromium.org/400623002/diff/1/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc File chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc (right): https://codereview.chromium.org/400623002/diff/1/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc#newcode153 chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc:153: ...
6 years, 5 months ago (2014-07-18 10:14:55 UTC) #2
pastarmovj
Also is there any chance to add a test for this code?
6 years, 5 months ago (2014-07-18 10:15:22 UTC) #3
Thiemo Nagel
Thank you! I'll add tests in a separate CL. https://codereview.chromium.org/400623002/diff/1/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc File chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc (right): https://codereview.chromium.org/400623002/diff/1/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc#newcode153 chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc:153: ...
6 years, 5 months ago (2014-07-18 11:54:04 UTC) #4
Thiemo Nagel
The CQ bit was checked by tnagel@chromium.org
6 years, 5 months ago (2014-07-18 11:59:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/400623002/20001
6 years, 5 months ago (2014-07-18 11:59:59 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 14:01:02 UTC) #7
Message was sent while issue was closed. 
Change committed as 284083

Powered by Google App Engine
This is Rietveld 408576698