Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 400613002: Remove a command line for NavigatorContentUtils (Closed)

Created:
6 years, 5 months ago by gyuyoung-inactive
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove a command line for NavigatorContentUtils NavigatorContentUtils is stable feature. So, we don't need to keep this command line flag. BUG=343941 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284040

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M content/child/runtime_features.cc View 1 chunk +0 lines, -3 lines 2 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
gyuyoung-inactive
PTAL
6 years, 5 months ago (2014-07-17 14:19:49 UTC) #1
Peter Kasting
LGTM but please also do the below https://codereview.chromium.org/400613002/diff/1/content/child/runtime_features.cc File content/child/runtime_features.cc (left): https://codereview.chromium.org/400613002/diff/1/content/child/runtime_features.cc#oldcode78 content/child/runtime_features.cc:78: WebRuntimeFeatures::enableNavigatorContentUtils(false); Are ...
6 years, 5 months ago (2014-07-17 18:24:03 UTC) #2
gyuyoung-inactive
https://codereview.chromium.org/400613002/diff/1/content/child/runtime_features.cc File content/child/runtime_features.cc (left): https://codereview.chromium.org/400613002/diff/1/content/child/runtime_features.cc#oldcode78 content/child/runtime_features.cc:78: WebRuntimeFeatures::enableNavigatorContentUtils(false); On 2014/07/17 18:24:03, Peter Kasting wrote: > Are ...
6 years, 5 months ago (2014-07-18 02:08:17 UTC) #3
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 5 months ago (2014-07-18 02:08:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/400613002/1
6 years, 5 months ago (2014-07-18 02:10:08 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 06:09:54 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 06:13:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/80807)
6 years, 5 months ago (2014-07-18 06:13:18 UTC) #8
gyuyoung-inactive
Add jochen. Jochen is one of owner for content
6 years, 5 months ago (2014-07-18 08:18:54 UTC) #9
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-18 08:50:07 UTC) #10
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 5 months ago (2014-07-18 09:21:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/400613002/1
6 years, 5 months ago (2014-07-18 09:21:41 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 09:26:13 UTC) #13
Message was sent while issue was closed.
Change committed as 284040

Powered by Google App Engine
This is Rietveld 408576698