Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 400583002: Change String.prototype.concat to be more like similar functions. (Closed)

Created:
6 years, 5 months ago by Yang
Modified:
6 years, 5 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Change String.prototype.concat to be more like similar functions. This is just cosmetic: We usually avoid using %FunctionSetLength. R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22447

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M src/string.js View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 5 months ago (2014-07-17 09:56:45 UTC) #1
Dmitry Lomov (no reviews)
lgtm
6 years, 5 months ago (2014-07-17 10:10:27 UTC) #2
Yang
6 years, 5 months ago (2014-07-17 10:54:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22447 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698