Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 400533008: Temporarily disable a webcrypto LayoutTest to allow landing a chromium side change. (Closed)

Created:
6 years, 5 months ago by eroman
Modified:
6 years, 5 months ago
Reviewers:
Ryan Sleevi
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Temporarily disable a webcrypto LayoutTest to allow landing a chromium side change. The Chromium change in question https://codereview.chromium.org/379383002/ will change two JWK errors, requiring the test to be rebased. BUG=374912 R=rsleevi@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178414

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
eroman
6 years, 5 months ago (2014-07-17 23:52:35 UTC) #1
Ryan Sleevi
It's just the JWK error details that are changing, right? The actual return code is ...
6 years, 5 months ago (2014-07-17 23:55:30 UTC) #2
eroman
Correct, it is the "details" part of the exception. The required rebaseline is: -error is: ...
6 years, 5 months ago (2014-07-18 00:05:27 UTC) #3
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 5 months ago (2014-07-18 00:42:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/400533008/1
6 years, 5 months ago (2014-07-18 00:42:34 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-18 01:42:32 UTC) #6
eroman
6 years, 5 months ago (2014-07-18 01:54:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r178414 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698