Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: cc/trees/layer_tree_host_impl.cc

Issue 400533006: Revert "Implement scroll handler latency tracking" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/trees/layer_tree_host_impl.h ('k') | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/trees/layer_tree_host_impl.h" 5 #include "cc/trees/layer_tree_host_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <limits> 8 #include <limits>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 485 matching lines...) Expand 10 before | Expand all | Expand 10 after
496 return layer_impl != NULL; 496 return layer_impl != NULL;
497 } 497 }
498 498
499 scoped_ptr<SwapPromiseMonitor> 499 scoped_ptr<SwapPromiseMonitor>
500 LayerTreeHostImpl::CreateLatencyInfoSwapPromiseMonitor( 500 LayerTreeHostImpl::CreateLatencyInfoSwapPromiseMonitor(
501 ui::LatencyInfo* latency) { 501 ui::LatencyInfo* latency) {
502 return scoped_ptr<SwapPromiseMonitor>( 502 return scoped_ptr<SwapPromiseMonitor>(
503 new LatencyInfoSwapPromiseMonitor(latency, NULL, this)); 503 new LatencyInfoSwapPromiseMonitor(latency, NULL, this));
504 } 504 }
505 505
506 void LayerTreeHostImpl::QueueSwapPromiseForMainThreadScrollUpdate(
507 scoped_ptr<SwapPromise> swap_promise) {
508 if (swap_promises_for_main_thread_scroll_update_.size() >
509 kMaxQueuedSwapPromiseNumber) {
510 BreakSwapPromisesForMainThreadScrollUpdate(
511 SwapPromise::SWAP_PROMISE_LIST_OVERFLOW);
512 }
513 swap_promises_for_main_thread_scroll_update_.push_back(swap_promise.Pass());
514 }
515
516 void LayerTreeHostImpl::BreakSwapPromisesForMainThreadScrollUpdate(
517 SwapPromise::DidNotSwapReason reason) {
518 for (size_t i = 0; i < swap_promises_for_main_thread_scroll_update_.size();
519 i++)
520 swap_promises_for_main_thread_scroll_update_[i]->DidNotSwap(reason);
521 swap_promises_for_main_thread_scroll_update_.clear();
522 }
523
524 void LayerTreeHostImpl::TrackDamageForAllSurfaces( 506 void LayerTreeHostImpl::TrackDamageForAllSurfaces(
525 LayerImpl* root_draw_layer, 507 LayerImpl* root_draw_layer,
526 const LayerImplList& render_surface_layer_list) { 508 const LayerImplList& render_surface_layer_list) {
527 // For now, we use damage tracking to compute a global scissor. To do this, we 509 // For now, we use damage tracking to compute a global scissor. To do this, we
528 // must compute all damage tracking before drawing anything, so that we know 510 // must compute all damage tracking before drawing anything, so that we know
529 // the root damage rect. The root damage rect is then used to scissor each 511 // the root damage rect. The root damage rect is then used to scissor each
530 // surface. 512 // surface.
531 513
532 for (int surface_index = render_surface_layer_list.size() - 1; 514 for (int surface_index = render_surface_layer_list.size() - 1;
533 surface_index >= 0; 515 surface_index >= 0;
(...skipping 2034 matching lines...) Expand 10 before | Expand all | Expand 10 after
2568 // which the layer moved. 2550 // which the layer moved.
2569 gfx::Vector2dF perpendicular_axis(-applied_delta.y(), applied_delta.x()); 2551 gfx::Vector2dF perpendicular_axis(-applied_delta.y(), applied_delta.x());
2570 pending_delta = MathUtil::ProjectVector(pending_delta, perpendicular_axis); 2552 pending_delta = MathUtil::ProjectVector(pending_delta, perpendicular_axis);
2571 2553
2572 if (gfx::ToRoundedVector2d(pending_delta).IsZero()) 2554 if (gfx::ToRoundedVector2d(pending_delta).IsZero())
2573 break; 2555 break;
2574 } 2556 }
2575 2557
2576 bool did_scroll_content = did_scroll_x || did_scroll_y; 2558 bool did_scroll_content = did_scroll_x || did_scroll_y;
2577 if (did_scroll_content) { 2559 if (did_scroll_content) {
2578 // If we are scrolling with an active scroll handler, forward latency
2579 // tracking information to the main thread so the delay introduced by the
2580 // handler is accounted for.
2581 if (scroll_affects_scroll_handler())
2582 NotifySwapPromiseMonitorsOfForwardingToMainThread();
2583 client_->SetNeedsCommitOnImplThread(); 2560 client_->SetNeedsCommitOnImplThread();
2584 SetNeedsRedraw(); 2561 SetNeedsRedraw();
2585 client_->RenewTreePriority(); 2562 client_->RenewTreePriority();
2586 } 2563 }
2587 2564
2588 // Scrolling along an axis resets accumulated root overscroll for that axis. 2565 // Scrolling along an axis resets accumulated root overscroll for that axis.
2589 if (did_scroll_x) 2566 if (did_scroll_x)
2590 accumulated_root_overscroll_.set_x(0); 2567 accumulated_root_overscroll_.set_x(0);
2591 if (did_scroll_y) 2568 if (did_scroll_y)
2592 accumulated_root_overscroll_.set_y(0); 2569 accumulated_root_overscroll_.set_y(0);
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
2874 for (size_t i = 0; i < layer_impl->children().size(); ++i) 2851 for (size_t i = 0; i < layer_impl->children().size(); ++i)
2875 CollectScrollDeltas(scroll_info, layer_impl->children()[i]); 2852 CollectScrollDeltas(scroll_info, layer_impl->children()[i]);
2876 } 2853 }
2877 2854
2878 scoped_ptr<ScrollAndScaleSet> LayerTreeHostImpl::ProcessScrollDeltas() { 2855 scoped_ptr<ScrollAndScaleSet> LayerTreeHostImpl::ProcessScrollDeltas() {
2879 scoped_ptr<ScrollAndScaleSet> scroll_info(new ScrollAndScaleSet()); 2856 scoped_ptr<ScrollAndScaleSet> scroll_info(new ScrollAndScaleSet());
2880 2857
2881 CollectScrollDeltas(scroll_info.get(), active_tree_->root_layer()); 2858 CollectScrollDeltas(scroll_info.get(), active_tree_->root_layer());
2882 scroll_info->page_scale_delta = active_tree_->page_scale_delta(); 2859 scroll_info->page_scale_delta = active_tree_->page_scale_delta();
2883 active_tree_->set_sent_page_scale_delta(scroll_info->page_scale_delta); 2860 active_tree_->set_sent_page_scale_delta(scroll_info->page_scale_delta);
2884 scroll_info->swap_promises.swap(swap_promises_for_main_thread_scroll_update_);
2885 2861
2886 return scroll_info.Pass(); 2862 return scroll_info.Pass();
2887 } 2863 }
2888 2864
2889 void LayerTreeHostImpl::SetFullRootLayerDamage() { 2865 void LayerTreeHostImpl::SetFullRootLayerDamage() {
2890 SetViewportDamage(gfx::Rect(DrawViewportSize())); 2866 SetViewportDamage(gfx::Rect(DrawViewportSize()));
2891 } 2867 }
2892 2868
2893 void LayerTreeHostImpl::RunOnDemandRasterTask(Task* on_demand_raster_task) { 2869 void LayerTreeHostImpl::RunOnDemandRasterTask(Task* on_demand_raster_task) {
2894 DCHECK(on_demand_task_graph_runner_); 2870 DCHECK(on_demand_task_graph_runner_);
(...skipping 356 matching lines...) Expand 10 before | Expand all | Expand 10 after
3251 void LayerTreeHostImpl::RemoveSwapPromiseMonitor(SwapPromiseMonitor* monitor) { 3227 void LayerTreeHostImpl::RemoveSwapPromiseMonitor(SwapPromiseMonitor* monitor) {
3252 swap_promise_monitor_.erase(monitor); 3228 swap_promise_monitor_.erase(monitor);
3253 } 3229 }
3254 3230
3255 void LayerTreeHostImpl::NotifySwapPromiseMonitorsOfSetNeedsRedraw() { 3231 void LayerTreeHostImpl::NotifySwapPromiseMonitorsOfSetNeedsRedraw() {
3256 std::set<SwapPromiseMonitor*>::iterator it = swap_promise_monitor_.begin(); 3232 std::set<SwapPromiseMonitor*>::iterator it = swap_promise_monitor_.begin();
3257 for (; it != swap_promise_monitor_.end(); it++) 3233 for (; it != swap_promise_monitor_.end(); it++)
3258 (*it)->OnSetNeedsRedrawOnImpl(); 3234 (*it)->OnSetNeedsRedrawOnImpl();
3259 } 3235 }
3260 3236
3261 void LayerTreeHostImpl::NotifySwapPromiseMonitorsOfForwardingToMainThread() {
3262 std::set<SwapPromiseMonitor*>::iterator it = swap_promise_monitor_.begin();
3263 for (; it != swap_promise_monitor_.end(); it++)
3264 (*it)->OnForwardScrollUpdateToMainThreadOnImpl();
3265 }
3266
3267 void LayerTreeHostImpl::RegisterPictureLayerImpl(PictureLayerImpl* layer) { 3237 void LayerTreeHostImpl::RegisterPictureLayerImpl(PictureLayerImpl* layer) {
3268 DCHECK(std::find(picture_layers_.begin(), picture_layers_.end(), layer) == 3238 DCHECK(std::find(picture_layers_.begin(), picture_layers_.end(), layer) ==
3269 picture_layers_.end()); 3239 picture_layers_.end());
3270 picture_layers_.push_back(layer); 3240 picture_layers_.push_back(layer);
3271 } 3241 }
3272 3242
3273 void LayerTreeHostImpl::UnregisterPictureLayerImpl(PictureLayerImpl* layer) { 3243 void LayerTreeHostImpl::UnregisterPictureLayerImpl(PictureLayerImpl* layer) {
3274 std::vector<PictureLayerImpl*>::iterator it = 3244 std::vector<PictureLayerImpl*>::iterator it =
3275 std::find(picture_layers_.begin(), picture_layers_.end(), layer); 3245 std::find(picture_layers_.begin(), picture_layers_.end(), layer);
3276 DCHECK(it != picture_layers_.end()); 3246 DCHECK(it != picture_layers_.end());
3277 picture_layers_.erase(it); 3247 picture_layers_.erase(it);
3278 } 3248 }
3279 3249
3280 } // namespace cc 3250 } // namespace cc
OLDNEW
« no previous file with comments | « cc/trees/layer_tree_host_impl.h ('k') | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698