Implements the dialog view for logout button tray in public sessions.

ash/system/logout_button/logout_confirmation_dialog_view.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ASH_SYSTEM_LOGOUT_BUTTON_LOGOUT_CONFIRMATION_DIALOG_VIEW_H_
+#define ASH_SYSTEM_LOGOUT_BUTTON_LOGOUT_CONFIRMATION_DIALOG_VIEW_H_
+
+#include "ash/ash_export.h"
+#include "base/basictypes.h"
+#include "base/compiler_specific.h"
+#include "base/time/time.h"
+#include "base/timer/timer.h"
+#include "ui/views/window/dialog_delegate.h"
+
+namespace views {
+class Label;
+}
+
+namespace ash {
+namespace internal {
+
+class LogoutButtonTray;
+
+// This class implements dialog view for logout confirmation.
+class ASH_EXPORT LogoutConfirmationDialogView
+    : public views::DialogDelegateView {
+ public:
+  // This class provide setting and interface for LogoutConfirmationDialogView.

[bartfab (slow), 2013/12/12 15:16:40]

Nit 1: s/provide/provides/
Nit 2: s/setting and interface/a setting and an interface/
Nit 3: I think this entire comment is unnecessary. It is clear what Delegates
are for.

[binjin, 2013/12/12 15:39:10]

Done.

+  // It's supposed to be overridden for testing purpose.
+  class ASH_EXPORT Delegate {
+   public:
+    Delegate();
+    virtual ~Delegate();
+
+    virtual void LogoutCurrentUser();
+    virtual base::TimeTicks GetCurrentTime();

[bartfab (slow), 2013/12/12 15:16:40]

Nit: const.

[binjin, 2013/12/12 15:39:10]

Done.

+    virtual base::TimeDelta GetUpdateInterval();

[bartfab (slow), 2013/12/12 15:16:40]

Nit: const.

[binjin, 2013/12/12 15:39:10]

Done.

+
+   private:
+    DISALLOW_COPY_AND_ASSIGN(Delegate);
+  };
+
+  LogoutConfirmationDialogView(LogoutButtonTray* owner, Delegate* delegate);
+  virtual ~LogoutConfirmationDialogView();
+
+  // views::DialogDelegateView:
+  virtual void DeleteDelegate() OVERRIDE;
+  virtual bool Accept() OVERRIDE;
+  virtual ui::ModalType GetModalType() const OVERRIDE;
+  virtual string16 GetWindowTitle() const OVERRIDE;
+  virtual string16 GetDialogButtonLabel(ui::DialogButton button) const OVERRIDE;
+  virtual void OnClosed() OVERRIDE;
+
+  void Show(base::TimeDelta duration);
+  void UpdateDialogDuration(base::TimeDelta duration);
+  void NullifyOwner();

[bartfab (slow), 2013/12/12 15:16:40]

This method is unnecessary. The *only* code path that reaches it is:

LogoutConfirmationDialogView::OnClosed()
  owner_->DeleteConfirmationDialog()
    LogoutConfirmationDialogView::NullifyOwner()
      which sets: owner_ = NULL

You could simplify this and remove the entirey NullifyOwner() by having
OnClosed() set owner_ = NULL.

[binjin, 2013/12/12 15:39:10]

Done.

+
+ private:
+  void LogoutCurrentUser();
+  void UpdateCountdown();
+
+  views::Label* text_label_;
+
+  base::TimeTicks countdown_start_time_;
+  base::TimeDelta duration_;
+
+  base::RepeatingTimer<LogoutConfirmationDialogView> timer_;
+
+  LogoutButtonTray* owner_;
+
+  Delegate* delegate_;
+
+  DISALLOW_COPY_AND_ASSIGN(LogoutConfirmationDialogView);
+};
+
+}  // namespace internal
+}  // namespace ash
+
+#endif  // ASH_SYSTEM_LOGOUT_BUTTON_LOGOUT_CONFIRMATION_DIALOG_VIEW_H_