Implements the dialog view for logout button tray in public sessions.

ash/system/logout_button/logout_confirmation_dialog_view.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ash/system/logout_button/logout_confirmation_dialog_view.h"
+
+#include "ash/shell.h"
+#include "ash/system/logout_button/logout_button_tray.h"

[bartfab (slow), 2013/12/10 12:41:16]

Nit: Actually not needed once you remove |owner| and |owner_|.

+#include "ash/system/tray/system_tray_delegate.h"
+#include "ash/system/tray/tray_constants.h"
+#include "base/location.h"
+#include "grit/ash_strings.h"
+#include "grit/ui_strings.h"

[bartfab (slow), 2013/12/10 12:41:16]

Nit: Where is this used?

[binjin, 2013/12/12 13:56:55]

Done.

+#include "ui/aura/root_window.h"
+#include "ui/base/l10n/l10n_util.h"
+#include "ui/base/l10n/time_format.h"
+#include "ui/base/ui_base_types.h"
+#include "ui/gfx/text_constants.h"
+#include "ui/views/controls/label.h"
+#include "ui/views/layout/fill_layout.h"
+#include "ui/views/layout/layout_constants.h"

[bartfab (slow), 2013/12/10 12:41:16]

Nit: Where is this used?

[binjin, 2013/12/12 13:56:55]

Done.

+#include "ui/views/widget/widget.h"
+
+namespace {
+
+const int kCountdownUpdateIntervalMs = 1000; // 1 second.

[bartfab (slow), 2013/12/10 12:41:16]

Nit: Two spaces between inline comment.

[binjin, 2013/12/12 13:56:55]

Done.

+
+}  // namespace
+
+namespace ash {
+namespace internal {
+
+LogoutConfirmationDialogView::LogoutConfirmationDelegate::
+    LogoutConfirmationDelegate() {
+}
+
+LogoutConfirmationDialogView::LogoutConfirmationDelegate::
+    ~LogoutConfirmationDelegate() {
+}
+
+void
+LogoutConfirmationDialogView::LogoutConfirmationDelegate::LogoutCurrentUser() {
+  if (Shell::HasInstance())
+    Shell::GetInstance()->system_tray_delegate()->SignOut();
+}
+
+base::TimeTicks LogoutConfirmationDialogView::LogoutConfirmationDelegate::
+    GetCurrentTime() {
+  return base::TimeTicks::Now();
+}
+
+base::TimeDelta LogoutConfirmationDialogView::LogoutConfirmationDelegate::
+    GetUpdateInterval() {
+  return base::TimeDelta::FromMilliseconds(kCountdownUpdateIntervalMs);

[bartfab (slow), 2013/12/10 12:41:16]

Nit: You could use FromSeconds(1), removing the need for a constant.

[binjin, 2013/12/12 13:56:55]

Done.

+}
+
+LogoutConfirmationDialogView::LogoutConfirmationDialogView(
+    base::WeakPtr<LogoutButtonTray> owner,
+    LogoutConfirmationDelegate* delegate) : owner_(owner), delegate_(delegate) {
+

[bartfab (slow), 2013/12/10 12:41:16]

Nit: Remove blank line.

[binjin, 2013/12/12 13:56:55]

Done.

+  text_label_ = new views::Label;
+  text_label_->set_border(
+      views::Border::CreateEmptyBorder(0, kTrayPopupPaddingHorizontal,

[bartfab (slow), 2013/12/10 12:41:16]

Nit: #include "ui/views/border.h"

[binjin, 2013/12/12 13:56:55]

Done.

+                                       0, kTrayPopupPaddingHorizontal));
+  text_label_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+  text_label_->SetMultiLine(true);
+
+  SetLayoutManager(new views::FillLayout());
+
+  AddChildView(text_label_);
+}
+
+LogoutConfirmationDialogView::~LogoutConfirmationDialogView() {
+}
+
+void LogoutConfirmationDialogView::DeleteDelegate() {

[bartfab (slow), 2013/12/10 12:41:16]

This is actually not needed. You could post a DeleteSoon for |this| instead.

+  if (owner_) {

[bartfab (slow), 2013/12/10 12:41:16]

Nit: No curly braces for single-line conditionals.

[binjin, 2013/12/12 13:56:55]

Done.

+    owner_->DeleteConfirmationDialog();
+  }
+}
+
+bool LogoutConfirmationDialogView::Accept() {
+  LogoutCurrentUser();
+  return true;
+}
+
+ui::ModalType LogoutConfirmationDialogView::GetModalType() const {
+  return ui::MODAL_TYPE_SYSTEM;
+}
+
+string16 LogoutConfirmationDialogView::GetWindowTitle() const {
+  return l10n_util::GetStringUTF16(IDS_ASH_LOGOUT_CONFIRMATION_TITLE);
+}
+
+string16 LogoutConfirmationDialogView::GetDialogButtonLabel(
+    ui::DialogButton button) const {
+  if (button == ui::DIALOG_BUTTON_OK)
+    return l10n_util::GetStringUTF16(IDS_ASH_LOGOUT_CONFIRMATION_BUTTON);
+  return views::DialogDelegateView::GetDialogButtonLabel(button);
+}
+
+void LogoutConfirmationDialogView::Show(base::TimeDelta duration) {
+  countdown_start_time_ = delegate_->GetCurrentTime();
+  duration_ = duration;
+
+  UpdateCountdown();
+
+  // For testint purpose, only run the actually display the dialog if an

[bartfab (slow), 2013/12/10 12:41:16]

Nit 1: s/testint/testing/.
Nit 2: s/run the//.

[binjin, 2013/12/12 13:56:55]

Done.

+  // existing ash::Shell is available.
+  if (ash::Shell::HasInstance()) {
+    views::DialogDelegate::CreateDialogWidget(
+        this, ash::Shell::GetPrimaryRootWindow(), NULL);
+    GetWidget()->Show();
+  }
+
+  timer_.Start(FROM_HERE,
+               delegate_->GetUpdateInterval(),
+               this,
+               &LogoutConfirmationDialogView::UpdateCountdown);
+}
+
+void LogoutConfirmationDialogView::UpdateDialogDuration(
+    base::TimeDelta duration) {
+  duration_ = duration;
+  UpdateCountdown();
+}
+
+void LogoutConfirmationDialogView::LogoutCurrentUser() {
+  // For testing purpose.
+  if (GetWidget()) {
+    GetWidget()->Close();
+    delegate_->LogoutCurrentUser();
+  } else {
+    delegate_->LogoutCurrentUser();
+    DeleteDelegate();
+  }
+}
+
+void LogoutConfirmationDialogView::UpdateCountdown() {
+  const base::TimeDelta time_remaining = countdown_start_time_

[bartfab (slow), 2013/12/10 12:41:16]

In its destructor, LogoutButtonTray calls
confirmation_dialog_->GetWidget()->Close(). From that point on, the
LogoutButtonTray and the
LogoutConfirmationDialogView::LogoutConfirmationDelegate that it owns are gone.
But the |timer_| here is still running. This may cause UpdateCountdown() to be
called, which will try to access a |delegate_| that no longer exists.

This class should react to OnClosed(). When the dialog is closed, the timer
should stop and the |delegate_| pointer should be reset. All accesses to
|delegate_| should check first whether it is not NULL so that even if one of
these methods is called somehow after the dialog has been closed, there are no
invalid accesses.

[binjin, 2013/12/12 13:56:55]

Done.

+      + duration_ - delegate_->GetCurrentTime();
+  // Round the remaining time to nearest second, and use this value for
+  // the count down display.

[bartfab (slow), 2013/12/10 12:41:16]

Nit 1: s/count down/countdown/.
Nit 2: Contrary to the comment, you use the rounded value for actual enforcement
as well. Either update the enforcement or the comment.

[binjin, 2013/12/12 13:56:55]

Done.

+  int seconds_remaining = (time_remaining

[bartfab (slow), 2013/12/10 12:41:16]

Nit: Why not round(InSecondsF())?

[binjin, 2013/12/12 13:56:55]

Done.

+      + base::TimeDelta::FromMilliseconds(500)).InSeconds();
+  if (seconds_remaining > 0) {
+    text_label_->SetText(l10n_util::GetStringFUTF16(
+        IDS_ASH_LOGOUT_CONFIRMATION_WARNING,
+        ui::TimeFormat::TimeDurationLong(base::TimeDelta::FromSeconds(
+            seconds_remaining))));
+  } else {
+    text_label_->SetText(l10n_util::GetStringUTF16(
+        IDS_ASH_LOGOUT_CONFIRMATION_WARNING_NOW));
+    timer_.Stop();
+    LogoutCurrentUser();
+  }
+}
+
+}  // namespace internal
+}  // namespace ash