Implements the dialog view for logout button tray in public sessions.

ash/system/logout_button/logout_button_tray.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_SYSTEM_LOGOUT_BUTTON_LOGOUT_BUTTON_TRAY_H_
 #define ASH_SYSTEM_LOGOUT_BUTTON_LOGOUT_BUTTON_TRAY_H_
 
+#include "ash/ash_export.h"
 #include "ash/system/logout_button/logout_button_observer.h"
+#include "ash/system/logout_button/logout_confirmation_dialog_view.h"
 #include "ash/system/tray/tray_background_view.h"
 #include "ash/system/user/login_status.h"
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"
+#include "base/time/time.h"
 #include "ui/views/controls/button/button.h"
 
 namespace views {
 class LabelButton;
 }
 
 namespace ash {
 namespace internal {
 
 class StatusAreaWidget;
+class LogoutConfirmationDialogTest;

[bartfab (slow), 2013/12/10 12:41:16]

Nit: This is not needed. Stating that LogoutConfirmationDialogTest is a friend
will automatically forward-declare it.

[binjin, 2013/12/12 13:56:55]

Done.

 
 // Adds a logout button to the launcher's status area if enabled by the
 // kShowLogoutButtonInTray pref.
-class LogoutButtonTray : public TrayBackgroundView,
-                         public LogoutButtonObserver,
-                         public views::ButtonListener {
+class ASH_EXPORT LogoutButtonTray : public TrayBackgroundView,
+                                    public LogoutButtonObserver,
+                                    public views::ButtonListener {
  public:
-  explicit LogoutButtonTray(StatusAreaWidget* status_area_widget);
+  friend class LogoutConfirmationDialogTest;

[bartfab (slow), 2013/12/10 12:41:16]

Nit: The friend declaration should go to the start of the private: section, best
followed by a blank line, i.e.:

 private:
  friend class LogoutConfirmationDialogTest;

  void UpdateVisibility();
  [...]

[binjin, 2013/12/12 13:56:55]

Done.

+  LogoutButtonTray(StatusAreaWidget* status_area_widget,

[bartfab (slow), 2013/12/10 12:41:16]

Nit: Indentation: All arguments must be aligned. In this case, you would want:

  LogoutButtonTray(
      StatusAreaWidget* status_area_widget,
      LogoutConfirmationDialogView::LogoutConfirmationDelegate* delegate);

[binjin, 2013/12/12 13:56:55]

Done.

+      LogoutConfirmationDialogView::LogoutConfirmationDelegate* delegate);

[bartfab (slow), 2013/12/10 12:41:16]

1) You are passing ownership of |delegate| here. Use a scoped_ptr.
2) Could you add a SetDelegateForTest() method instead? That way, there will be
no need to pass a NULL in in the default code flow.

[binjin, 2013/12/12 13:56:55]

Done.

   virtual ~LogoutButtonTray();
 
+  void EnsureConfirmationDialogIsShowing();
+  void EnsureConfirmationDialogIsClosed();
+  bool IsConfirmationDialogShowing();

[bartfab (slow), 2013/12/10 12:41:16]

Nit 1: Getters usually go before setters. Thus, IsConfirmationDialogShowing()
should be first.

Nit 2: Make IsConfirmationDialogShowing() const.

[binjin, 2013/12/12 13:56:55]

Done.

+
   // TrayBackgroundView:
   virtual void SetShelfAlignment(ShelfAlignment alignment) OVERRIDE;
   virtual base::string16 GetAccessibleNameForTray() OVERRIDE;
   virtual void HideBubbleWithView(
       const views::TrayBubbleView* bubble_view) OVERRIDE;
   virtual bool ClickedOutsideBubble() OVERRIDE;
 
   // LogoutButtonObserver:
   virtual void OnShowLogoutButtonInTrayChanged(bool show) OVERRIDE;
+  virtual void OnLogoutDialogDurationChanged(base::TimeDelta duration) OVERRIDE;
 
   // views::ButtonListener:
   virtual void ButtonPressed(views::Button* sender,
                              const ui::Event& event) OVERRIDE;
 
   void UpdateAfterLoginStatusChange(user::LoginStatus login_status);
 
+  void DeleteConfirmationDialog();
+
+  LogoutConfirmationDialogView* GetConfirmationDialogForTest();
+  LogoutConfirmationDialogView::LogoutConfirmationDelegate*
+      GetConfirmationDelegateForTest();
+
  private:
   void UpdateVisibility();
 
   views::LabelButton* button_;  // Not owned.
   user::LoginStatus login_status_;
   bool show_logout_button_in_tray_;
+  base::TimeDelta dialog_duration_;
+
+  scoped_ptr<LogoutConfirmationDialogView> confirmation_dialog_;
+  scoped_ptr<LogoutConfirmationDialogView::LogoutConfirmationDelegate>
+      confirmation_delegate_;
+  base::WeakPtrFactory<LogoutButtonTray> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(LogoutButtonTray);
 };
 
 }  // namespace internal
 }  // namespace ash
 
 #endif  // ASH_SYSTEM_LOGOUT_BUTTON_LOGOUT_BUTTON_TRAY_H_