Implements the dialog view for logout button tray in public sessions.

ash/system/logout_button/logout_button_tray.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_SYSTEM_LOGOUT_BUTTON_LOGOUT_BUTTON_TRAY_H_
 #define ASH_SYSTEM_LOGOUT_BUTTON_LOGOUT_BUTTON_TRAY_H_
 
 #include "ash/system/logout_button/logout_button_observer.h"
 #include "ash/system/tray/tray_background_view.h"
 #include "ash/system/user/login_status.h"
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/time/time.h"
 #include "ui/views/controls/button/button.h"
 
 namespace views {
 class LabelButton;
 }
 
 namespace ash {
 namespace internal {
 
+class LogoutConfirmationDialogView;
 class StatusAreaWidget;
 
 // Adds a logout button to the launcher's status area if enabled by the
 // kShowLogoutButtonInTray pref.
 class LogoutButtonTray : public TrayBackgroundView,
                          public LogoutButtonObserver,
                          public views::ButtonListener {
  public:
   explicit LogoutButtonTray(StatusAreaWidget* status_area_widget);
   virtual ~LogoutButtonTray();
 
+  void EnsureConfirmationDialogIsShowing();
+  void EnsureConfirmationDialogIsClosed();
+
   // TrayBackgroundView:
   virtual void SetShelfAlignment(ShelfAlignment alignment) OVERRIDE;
   virtual base::string16 GetAccessibleNameForTray() OVERRIDE;
   virtual void HideBubbleWithView(
       const views::TrayBubbleView* bubble_view) OVERRIDE;
   virtual bool ClickedOutsideBubble() OVERRIDE;
 
   // LogoutButtonObserver:
   virtual void OnShowLogoutButtonInTrayChanged(bool show) OVERRIDE;
+  virtual void OnLogoutDialogDurationChanged(base::TimeDelta duration) OVERRIDE;
 
   // views::ButtonListener:
   virtual void ButtonPressed(views::Button* sender,
                              const ui::Event& event) OVERRIDE;
 
   void UpdateAfterLoginStatusChange(user::LoginStatus login_status);
 
+  LogoutConfirmationDialogView* UnbindWithConfirmationDialog();

[bartfab (slow), 2013/11/20 18:00:44]

In general, the approach looks good but is overly complex:

* If the LogoutConfirmationDialogView is destroyed first, it would be sufficient
if it called a method named something like OnConfirmationDialogViewDestroyed()
which simply releases the confirmation_dialog_ pointer.

* You could make the LogoutConfirmationDialogView's owner_ pointer a WeakPtr.
LogoutButtonTray would have a weak_factory_ that this WeakPtr comes from. That
way, there would be no need to tell the dialog when its owner goes away. You
could then fold UnbindWithConfirmationDialog() into
EnsureConfirmationDialogIsClosed() and simplify it to:

void LogoutButtonTray::EnsureConfirmationDialogIsClosed() {
if (confirmation_dialog_) {
  weak_factory_.InvalidateWeakPtrs();
  confirmation_dialog_->GetWidget()->Close();
  base::MessageLoop::current()->DeleteSoon(FROM_HERE,
confirmation_dialog_.release());
}

Finally, three more nits:

1/ "Bind" has a very specific meaning in Chrome (it refers to base::Bind), so
you should not be using "bind" and "unbind" for naming unrelated methods.

2/ There is no need to warn that a method is not thread-safe. All Chrome code is
assumed to be non-thread-safe unless explicitly stated otherwise.

3/ The method is actually not atomic (i.e., it performs a sequence of
operations, not a single atomic one), so better do not document it as such :).

+
  private:
   void UpdateVisibility();
 
   views::LabelButton* button_;  // Not owned.
   user::LoginStatus login_status_;
   bool show_logout_button_in_tray_;
+  base::TimeDelta dialog_duration_;
+
+  scoped_ptr<LogoutConfirmationDialogView> confirmation_dialog_;
 
   DISALLOW_COPY_AND_ASSIGN(LogoutButtonTray);
 };
 
 }  // namespace internal
 }  // namespace ash
 
 #endif  // ASH_SYSTEM_LOGOUT_BUTTON_LOGOUT_BUTTON_TRAY_H_