Cache IC handlers on the prototype's map if possible

Cache IC handlers on the prototype's map if possible

instead of on the receiver's map. Lazily overwrite cached handler if it is
identical to the handler that just missed.

R=verwaest@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22483

[Jakob Kummerow, 2014-07-17 13:49:01]

PTAL.

[Toon Verwaest, 2014-07-18 13:12:24]

lgtm

https://codereview.chromium.org/400523007/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/400523007/diff/1/src/hydrogen.cc#newcode6128
src/hydrogen.cc:6128: JSFunction* ctor = IC::GetBuiltinConstructor(
Can you rename this to GetRootConstructor?

https://codereview.chromium.org/400523007/diff/1/src/ic.cc
File src/ic.cc (right):

https://codereview.chromium.org/400523007/diff/1/src/ic.cc#newcode924
src/ic.cc:924: isolate()->stub_cache()->Get(*name, map, code->flags());
Probably should move this closer to where we get the monomorphic / polymorphic
handlers. For this CL this is fine though.

https://codereview.chromium.org/400523007/diff/1/src/ic.cc#newcode936
src/ic.cc:936: Map::UpdateCodeCache(stub_holder_map, name, code);
Nice :)

[Jakob Kummerow, 2014-07-18 13:47:52]

https://codereview.chromium.org/400523007/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/400523007/diff/1/src/hydrogen.cc#newcode6128
src/hydrogen.cc:6128: JSFunction* ctor = IC::GetBuiltinConstructor(
On 2014/07/18 13:12:23, Toon Verwaest wrote:
> Can you rename this to GetRootConstructor?

Done.

https://codereview.chromium.org/400523007/diff/1/src/ic.cc
File src/ic.cc (right):

https://codereview.chromium.org/400523007/diff/1/src/ic.cc#newcode924
src/ic.cc:924: isolate()->stub_cache()->Get(*name, map, code->flags());
On 2014/07/18 13:12:23, Toon Verwaest wrote:
> Probably should move this closer to where we get the monomorphic / polymorphic
> handlers. For this CL this is fine though.

Ack. The difficulty is that where maybe_handler_ is populated, we don't have the
code flags we need for the megamorphic stub cache lookup.

https://codereview.chromium.org/400523007/diff/1/src/ic.cc#newcode936
src/ic.cc:936: Map::UpdateCodeCache(stub_holder_map, name, code);
On 2014/07/18 13:12:24, Toon Verwaest wrote:
> Nice :)

:-)

[Jakob Kummerow, 2014-07-18 13:50:39]

Committed patchset #2 manually as r22483 (presubmit successful).