Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 400523004: ClickToPlayPluginTest.NoCallbackAtLoad test should create head element (Closed)

Created:
6 years, 5 months ago by kangil_
Modified:
6 years, 5 months ago
CC:
chromium-reviews, markusheintz_
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ClickToPlayPluginTest.NoCallbackAtLoad test should create head element SPEC: http://www.whatwg.org/specs/web-apps/current-work/#document.title According to spec, set title without head element should be aborted in steps. So to continue test as well as follow spec, NoCallbackAtLoad test case should create head element before setting title. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283773

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/content_settings/content_settings_browsertest.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kangil_
https://codereview.chromium.org/384413003/ depends on this CL
6 years, 5 months ago (2014-07-17 07:20:41 UTC) #1
kangil_
PTAL
6 years, 5 months ago (2014-07-17 07:21:29 UTC) #2
haraken
LGTM, but I'm not an owner of the directory.
6 years, 5 months ago (2014-07-17 07:56:44 UTC) #3
kangil_
@jochen: PTAL.
6 years, 5 months ago (2014-07-17 08:07:09 UTC) #4
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-17 09:10:26 UTC) #5
kangil_
The CQ bit was checked by kangil.han@samsung.com
6 years, 5 months ago (2014-07-17 10:40:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/400523004/1
6 years, 5 months ago (2014-07-17 10:41:59 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 12:38:19 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 14:15:00 UTC) #9
Message was sent while issue was closed.
Change committed as 283773

Powered by Google App Engine
This is Rietveld 408576698