Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: chrome/browser/prerender/prerender_browsertest.cc

Issue 400493004: Disable failing unit test (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: From the right branch this time. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_browsertest.cc
diff --git a/chrome/browser/prerender/prerender_browsertest.cc b/chrome/browser/prerender/prerender_browsertest.cc
index 20c9d5b6800ea097161ae01f275c3fdf1e1d924a..e50f31e3e21b253036b75a7c60255152cc13faaa 100644
--- a/chrome/browser/prerender/prerender_browsertest.cc
+++ b/chrome/browser/prerender/prerender_browsertest.cc
@@ -4380,8 +4380,18 @@ IN_PROC_BROWSER_TEST_F(PrerenderOmniboxBrowserTest, PrerenderOmniboxCancel) {
prerender->WaitForStop();
}
+// Crashes on windows. The failure seems to be that the PrerenderOmniboxAbandon
+// test is setting up a call to the windows API RegisterApplicationRestart with
+// a command line that is too long (> 1024 characters).
+#if defined(OS_WIN) || defined(OS_MACOSX)
+#define MAYBE_PrerenderOmniboxAbandon DISABLED_PrerenderOmniboxAbandon
+#else
+#define MAYBE_PrerenderOmniboxAbandon PrerenderOmniboxAbandon
+#endif
+
// Checks that accepting omnibox input abandons an omnibox prerender.
-IN_PROC_BROWSER_TEST_F(PrerenderOmniboxBrowserTest, PrerenderOmniboxAbandon) {
+IN_PROC_BROWSER_TEST_F(PrerenderOmniboxBrowserTest,
+ MAYBE_PrerenderOmniboxAbandon) {
// Set the abandon timeout to something high so it does not introduce
// flakiness if the prerender times out before the test completes.
GetPrerenderManager()->mutable_config().abandon_time_to_live =
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698