Hide dangerous interface String::Equals/Hash(uint8_t*,...

runtime/vm/object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OBJECT_H_
 #define VM_OBJECT_H_
 
 #include <limits>
 #include "include/dart_api.h"
 #include "platform/assert.h"
@@ skipping 5339 matching lines @@
     if (result != 0) {
       return result;
     }
     result = String::Hash(*this, 0, this->Length());
     this->SetHash(result);
     return result;
   }
 
   static intptr_t hash_offset() { return OFFSET_OF(RawString, hash_); }
   static intptr_t Hash(const String& str, intptr_t begin_index, intptr_t len);
-  static intptr_t Hash(const uint8_t* characters, intptr_t len);
+  static intptr_t HashLatin1(const uint8_t* characters, intptr_t len);
   static intptr_t Hash(const uint16_t* characters, intptr_t len);
   static intptr_t Hash(const int32_t* characters, intptr_t len);
 
   virtual RawObject* HashCode() const { return Integer::New(Hash()); }
 
   int32_t CharAt(intptr_t index) const;
 
   Scanner::CharAtFunc CharAtFunc() const;
 
   intptr_t CharSize() const;
 
   inline bool Equals(const String& str) const;
   inline bool Equals(const String& str,
                      intptr_t begin_index,  // begin index on 'str'.
                      intptr_t len) const;  // len on 'str'.
 
   // Compares to a '\0' terminated array of UTF-8 encoded characters.
   bool Equals(const char* cstr) const;
 
-  // Compares to an array of UTF-8 encoded characters.
-  bool Equals(const uint8_t* characters, intptr_t len) const;
+  // Compares to an array of Latin-1 encoded characters.
+  bool EqualsLatin1(const uint8_t* characters, intptr_t len) const {
+    return Equals(characters, len);
+  }
 
   // Compares to an array of UTF-16 encoded characters.
   bool Equals(const uint16_t* characters, intptr_t len) const;
 
   // Compares to an array of UTF-32 encoded characters.
   bool Equals(const int32_t* characters, intptr_t len) const;
 
   virtual bool OperatorEquals(const Instance& other) const {
     return Equals(other);
   }
@@ skipping 145 matching lines @@
   static RawString* NewFormatted(const char* format, ...)
       PRINTF_ATTRIBUTE(1, 2);
   static RawString* NewFormattedV(const char* format, va_list args);
 
   static bool ParseDouble(const String& str,
                           intptr_t start,
                           intptr_t end,
                           double* result);
 
  protected:
+  // These two operate on an array of Latin-1 encoded characters.
+  // They are protected to avoid mistaking Latin-1 for UTF-8, but used
+  // by friendly templated code (e.g., Symbols).
+  bool Equals(const uint8_t* characters, intptr_t len) const;
+  static intptr_t Hash(const uint8_t* characters, intptr_t len);
+
   bool HasHash() const {
     ASSERT(Smi::New(0) == NULL);
     return (raw_ptr()->hash_ != NULL);
   }
 
   void SetLength(intptr_t value) const {
     // This is only safe because we create a new Smi, which does not cause
     // heap allocation.
     raw_ptr()->length_ = Smi::New(value);
   }
@@ skipping 1628 matching lines @@
 
 
 RawObject* MegamorphicCache::GetTargetFunction(const Array& array,
                                                intptr_t index) {
   return array.At((index * kEntryLength) + kTargetFunctionIndex);
 }
 
 }  // namespace dart
 
 #endif  // VM_OBJECT_H_