Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: content/child/webcrypto/shared_crypto_unittest.cc

Issue 400473003: [webcrypto] Support 256-bit AES-GCM for OpenSSL implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/webcrypto/openssl/aes_gcm_openssl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/webcrypto/shared_crypto_unittest.cc
diff --git a/content/child/webcrypto/shared_crypto_unittest.cc b/content/child/webcrypto/shared_crypto_unittest.cc
index b6fa177db7da2a99daeb9d6f26f5eb18b07fc882..39323a24cf64c20c37b102ae1a6790fc661f0f81 100644
--- a/content/child/webcrypto/shared_crypto_unittest.cc
+++ b/content/child/webcrypto/shared_crypto_unittest.cc
@@ -3286,15 +3286,6 @@ TEST_F(SharedCryptoTest, AesGcmSampleSets) {
const std::vector<uint8_t> test_cipher_text =
GetBytesFromHexString(test, "cipher_text");
-#if defined(USE_OPENSSL)
- // TODO(eroman): Add support for 256-bit keys.
- if (test_key.size() == 32) {
- LOG(WARNING)
- << "OpenSSL doesn't support 256-bit keys for AES-GCM; skipping";
- continue;
- }
-#endif
-
blink::WebCryptoKey key = ImportSecretKeyFromRaw(
test_key,
CreateAlgorithm(blink::WebCryptoAlgorithmIdAesGcm),
« no previous file with comments | « content/child/webcrypto/openssl/aes_gcm_openssl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698