Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issue 400473002: Oilpan: remove now-unused WebNode(Member<T>) constructor. (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 5 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: remove now-unused WebNode(Member<T>) constructor. The (implicit) construction of a WebNode from a Member<T> (where T is convertible to a Node) was introduced to allow for assignment of a Member<Element> to a WebNode (as needed by http://crrev.com/280123002/) With http://crrev.com/313813002 (r175522), an operator conversion from Member<T> to RawPtr<T> was introduced, which makes the reason for having the above WebNode() constructor fall away. Remove it here. R=abarth@chromium.org BUG=357163 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178296

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M public/web/WebNode.h View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
Please take a look. The addition of the #define mapping WebCore to blink in Source/config.h ...
6 years, 5 months ago (2014-07-16 21:12:32 UTC) #1
abarth-chromium
LGTM
6 years, 5 months ago (2014-07-16 21:21:46 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-16 21:23:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/400473002/1
6 years, 5 months ago (2014-07-16 21:24:34 UTC) #4
commit-bot: I haz the power
Change committed as 178296
6 years, 5 months ago (2014-07-16 21:25:58 UTC) #5
haraken
6 years, 5 months ago (2014-07-16 23:15:09 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698