Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 400453002: Remove ambiguous operator= on AutoCFRelease. (Closed)

Created:
6 years, 5 months ago by bungeman-skia
Modified:
6 years, 5 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove ambiguous operator= on AutoCFRelease. The operator= is ambiguous as to the state of the reference count. Until we have rvalue assignment operators, just use 'reset' as the name of the reference stealing assignment to AutoCFRelease. Committed: https://skia.googlesource.com/skia/+/e194c495e95cbe92dfb9ed04515904a417fe7e9b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M src/ports/SkFontHost_mac.cpp View 4 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bungeman-skia
This is a continuation of the CGBitmap leak CL which went in earlier. The idea ...
6 years, 5 months ago (2014-07-16 19:48:47 UTC) #1
mtklein
lgtm
6 years, 5 months ago (2014-07-16 20:21:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/400453002/1
6 years, 5 months ago (2014-07-16 20:22:59 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 20:46:14 UTC) #4
Message was sent while issue was closed.
Change committed as e194c495e95cbe92dfb9ed04515904a417fe7e9b

Powered by Google App Engine
This is Rietveld 408576698