Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 400443002: Use label native theme colors for drag images. (Closed)

Created:
6 years, 5 months ago by msw
Modified:
6 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, dcheng
Visibility:
Public.

Description

Use label native theme colors for drag images. r280376 changed the button drag image painting code. The label colors used make the text appear blurry. Use label native theme colors instead of button colors. (the black-on-white looks better than black-on-gray) See before/after pics at http://crbug.com/394245#c4 BUG=394245 TEST=Bookmark/URL drag images look okay. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283644

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/views/button_drag_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
msw
Hey Scott, please take a look; thanks!
6 years, 5 months ago (2014-07-16 19:26:03 UTC) #1
sky
LGTM
6 years, 5 months ago (2014-07-16 21:15:40 UTC) #2
msw
The CQ bit was checked by msw@chromium.org
6 years, 5 months ago (2014-07-16 21:16:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/400443002/1
6 years, 5 months ago (2014-07-16 21:18:28 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 04:35:14 UTC) #5
Message was sent while issue was closed.
Change committed as 283644

Powered by Google App Engine
This is Rietveld 408576698