Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1845)

Unified Diff: Tools/GardeningServer/scripts/svn-log.js

Issue 400423002: Remove base.* methods. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/scripts/svn-log.js
diff --git a/Tools/GardeningServer/scripts/svn-log.js b/Tools/GardeningServer/scripts/svn-log.js
index 58d5128cb17e254dd4db4a3f68c30224c2ee8d28..cd53f288af89c50208e661fe0c32e4f45db73842 100644
--- a/Tools/GardeningServer/scripts/svn-log.js
+++ b/Tools/GardeningServer/scripts/svn-log.js
@@ -114,13 +114,25 @@ function parseCommitData(responseXML)
return commits;
}
+trac._queryParam = function(params)
+{
+ var result = []
+ Object.keys(params, function(key, value) {
+ result.push(encodeURIComponent(key) + '=' + encodeURIComponent(value));
+ });
+ // FIXME: Remove the conversion of space to plus. This is just here
+ // to remain compatible with jQuery.param, but there's no reason to
+ // deviate from the built-in encodeURIComponent behavior.
+ return result.join('&').replace(/%20/g, '+');
+}
+
trac.changesetURL = function(revision)
{
var queryParameters = {
view: 'rev',
revision: revision,
};
- return config.kBlinkRevisionURL + '?' + base.queryParam(queryParameters);
+ return config.kBlinkRevisionURL + '?' + trac._queryParam(queryParameters);
};
trac.recentCommitData = function(path, limit)
« no previous file with comments | « Tools/GardeningServer/scripts/results_unittests.js ('k') | Tools/GardeningServer/scripts/svn-log_unittests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698