Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Side by Side Diff: Tools/GardeningServer/scripts/svn-log.js

Issue 400423002: Remove base.* methods. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2011 Apple Inc. All rights reserved.
3 * Copyright (C) 2012 Google Inc. All rights reserved. 3 * Copyright (C) 2012 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 'author': author, 107 'author': author,
108 'reviewer': message.reviewer, 108 'reviewer': message.reviewer,
109 'bugID': message.bugID, 109 'bugID': message.bugID,
110 'message': message.summary, 110 'message': message.summary,
111 'revertedRevision': undefined, 111 'revertedRevision': undefined,
112 }; 112 };
113 }); 113 });
114 return commits; 114 return commits;
115 } 115 }
116 116
117 trac._queryParam = function(params)
118 {
119 var result = []
120 Object.keys(params, function(key, value) {
121 result.push(encodeURIComponent(key) + '=' + encodeURIComponent(value));
122 });
123 // FIXME: Remove the conversion of space to plus. This is just here
124 // to remain compatible with jQuery.param, but there's no reason to
125 // deviate from the built-in encodeURIComponent behavior.
126 return result.join('&').replace(/%20/g, '+');
127 }
128
117 trac.changesetURL = function(revision) 129 trac.changesetURL = function(revision)
118 { 130 {
119 var queryParameters = { 131 var queryParameters = {
120 view: 'rev', 132 view: 'rev',
121 revision: revision, 133 revision: revision,
122 }; 134 };
123 return config.kBlinkRevisionURL + '?' + base.queryParam(queryParameters); 135 return config.kBlinkRevisionURL + '?' + trac._queryParam(queryParameters);
124 }; 136 };
125 137
126 trac.recentCommitData = function(path, limit) 138 trac.recentCommitData = function(path, limit)
127 { 139 {
128 return net.xml('http://blink.lc/blink/atom').then(function(commitData) { 140 return net.xml('http://blink.lc/blink/atom').then(function(commitData) {
129 return parseCommitData(commitData); 141 return parseCommitData(commitData);
130 }); 142 });
131 }; 143 };
132 144
133 })(); 145 })();
OLDNEW
« no previous file with comments | « Tools/GardeningServer/scripts/results_unittests.js ('k') | Tools/GardeningServer/scripts/svn-log_unittests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698