Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 40042: Add trivial theming support in extensions.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 2 months ago by Erik does not do reviews
Modified:
6 years ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add trivial theming support in extensions. NOTE: This is not final API. It *will* change. It's purely for testing purposes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10913

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Total comments: 2

Patch Set 7 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -14 lines) Patch
M base/version.h View 2 3 4 5 6 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension.h View 1 2 3 4 5 6 7 chunks +17 lines, -4 lines 2 comments Download
M chrome/browser/extensions/extension.cc View 1 2 3 4 5 6 5 chunks +39 lines, -0 lines 0 comments Download
M chrome/common/resource_bundle.h View 1 2 3 4 5 6 5 chunks +8 lines, -1 line 0 comments Download
M chrome/common/resource_bundle.cc View 1 2 3 4 5 6 4 chunks +40 lines, -6 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 6 (0 generated)
Erik does not do reviews
8 years, 2 months ago (2009-03-04 01:05:15 UTC) #1
Aaron Boodman
Hacktastic! LGTM Feel free to not make the change I suggested to Version or delay ...
8 years, 2 months ago (2009-03-04 03:32:48 UTC) #2
Glen Murphy
LGTM, one ignorable nit: http://codereview.chromium.org/40042/diff/1029/41 File chrome/browser/extensions/extension.cc (right): http://codereview.chromium.org/40042/diff/1029/41#newcode249 Line 249: if (source.HasKey(L"theme")) { Should ...
8 years, 2 months ago (2009-03-04 19:12:38 UTC) #3
Erik does not do reviews
new snap uploaded. (got rid of most of version changes)
8 years, 2 months ago (2009-03-04 19:35:56 UTC) #4
Aaron Boodman
LGTM http://codereview.chromium.org/40042/diff/56/1038 File chrome/browser/extensions/extension.h (right): http://codereview.chromium.org/40042/diff/56/1038#newcode110 Line 110: Version* version() const { return version_.get(); } ...
8 years, 2 months ago (2009-03-04 20:19:26 UTC) #5
Erik does not do reviews
8 years, 2 months ago (2009-03-04 20:21:54 UTC) #6
http://codereview.chromium.org/40042/diff/56/1038
File chrome/browser/extensions/extension.h (right):

http://codereview.chromium.org/40042/diff/56/1038#newcode110
Line 110: Version* version() const { return version_.get(); }
On 2009/03/04 20:19:27, Aaron Boodman wrote:
> Did you mean to change this to a mutable instance?

nope, good catch.  fixed and committing (when the tree is open).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06