Add trivial theming support in extensions....

Add trivial theming support in extensions.
NOTE: This is not final API.  It *will* change.  It's purely for testing purposes.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10913

[Aaron Boodman, 2009-03-04 03:32:48]

Hacktastic! LGTM

Feel free to not make the change I suggested to Version or delay it to another
CL.

http://codereview.chromium.org/40042/diff/1029/46
File base/version.h (right):

http://codereview.chromium.org/40042/diff/1029/46#newcode34
Line 34: bool IsValid() { return components_.size() > 0; }
The previous design of this where you couldn't have an invalid Version was nice
(and better than my dumb Extension objects that can be invalid).

Maybe consider leaving it as-is and manually copying these in Extension's copy
constructor?

[Glen Murphy, 2009-03-04 19:12:38]

LGTM, one ignorable nit:

http://codereview.chromium.org/40042/diff/1029/41
File chrome/browser/extensions/extension.cc (right):

http://codereview.chromium.org/40042/diff/1029/41#newcode249
Line 249: if (source.HasKey(L"theme")) {
Should we make an Extension::kThemesKey ?

[Erik does not do reviews, 2009-03-04 19:35:56]

new snap uploaded.  (got rid of most of version changes)

[Aaron Boodman, 2009-03-04 20:19:26]

LGTM

http://codereview.chromium.org/40042/diff/56/1038
File chrome/browser/extensions/extension.h (right):

http://codereview.chromium.org/40042/diff/56/1038#newcode110
Line 110: Version* version() const { return version_.get(); }
Did you mean to change this to a mutable instance?

[Erik does not do reviews, 2009-03-04 20:21:54]

http://codereview.chromium.org/40042/diff/56/1038
File chrome/browser/extensions/extension.h (right):

http://codereview.chromium.org/40042/diff/56/1038#newcode110
Line 110: Version* version() const { return version_.get(); }
On 2009/03/04 20:19:27, Aaron Boodman wrote:
> Did you mean to change this to a mutable instance?

nope, good catch.  fixed and committing (when the tree is open).